[Namespace]: Simplify sync_d functions to use higher order #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
functions. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
reviewed
Jul 28, 2020
src/sonic_ax_impl/mibs/__init__.py
Outdated
| result_map[idx].update(ns_tuple[idx]) | ||
| for idx, ns_tuple_dict in result_map.items(): | ||
| result_list.append(ns_tuple_dict) | ||
| return(result_list) |
There was a problem hiding this comment.
Suggested change
| return(result_list) | |
| return result_list | |
| ``` #Closed |
There was a problem hiding this comment.
Updated as per comment.
qiluo-msft
reviewed
Jul 28, 2020
src/sonic_ax_impl/mibs/__init__.py
Outdated
| """ | ||
| Namespace.connect_namespace_dbs(dbs) | ||
| def get_sync_d_from_all_namespace(per_namespace_func, dbs): | ||
| # return list of dictionaries retrieved from per namespace functions |
There was a problem hiding this comment.
return list of dictionaries [](start = 10, length = 27)
You did not return list of dictionaries #Closed
There was a problem hiding this comment.
we return list of dictionaries, the dictionaries will be the same as return from individual sync_d functions, just that they are merged together.
There was a problem hiding this comment.
Probably, we can say "return tuple of dictionaries"
There was a problem hiding this comment.
Updated as per review comment.
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
approved these changes
Jul 30, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 2, 2020
* [Namespace]: Simplify sync_d functions to use higher order functions. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com> * Update as per review comments. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functions.
Signed-off-by: SuvarnaMeenakshi sumeenak@microsoft.com
- What I did
Namespace class was added to support getting data from multiple namespaces.
This class includes some functions which get data from multiple namespaces and combine them.
This PR is to simplify the function of getting from separate functions and merge them.
- How I did it
Write a higher order function to invoke individual function to retrieve data from a single namespace.
The higher order function will retrieve the data and combine.
- How to verify it
No change in single and multi-asic snmp walk outputs.
Only implementation changes.
Make sure snmp walk outputs before change and after change are the same.
- Description for the changelog