[LLDP]: Modify OID index of LLDPRemTableUpdater MIB #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(if index, remote time mark, remote device index). In case of multi-asic platform, when querying this MIB it can happen that same if index result is seen in SNMP walk, with a different remote time mark. To avoid showing same if index result in the result, set remote time mark to 0. Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
Signed-off-by: SuvarnaMeenakshi <sumeenak@microsoft.com>
qiluo-msft
approved these changes
Aug 3, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 2, 2020
* [LLDP]: LLDPRemTableUpdater index in OID is a tuple of (if index, remote time mark, remote device index). In case of multi-asic platform, when querying this MIB it can happen that same if index result is seen in SNMP walk, with a different remote time mark. To avoid showing same if index result in the result, set remote time mark to 0. * Add code comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
LLDPRemTableUpdater index in OID is a tuple of (remote time mark, if index, remote device index).
In case of multi-asic platform, when querying this MIB it can happen that same if index result is seen in SNMP walk, with a different remote time mark.
In the above walk, 177 interface index data appears twice.
- How I did it
To avoid showing same if index result in the result, set remote time mark to 0, as this value is not significant,
- How to verify it
Make sure the output of single asic platform shows the same result as before but with OID modified as: lldpRemSysName.0.if_index.remote_dev_id.
This will take effect in the entire LLDPRemTableUpdater table.
Make sure the output on mulit asic platform shows the result with unique interface index.
- Description for the changelog