Add schema for ACL: APP_ACL_TABLE and APP_ACL_RULE_TABLE (#325) #275
Conversation
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
common/schema.h
Outdated
| @@ -39,6 +39,8 @@ namespace swss { | |||
| #define APP_VXLAN_VRF_TABLE_NAME "VXLAN_VRF_TABLE" | |||
| #define APP_VXLAN_TUNNEL_MAP_TABLE_NAME "VXLAN_TUNNEL_MAP_TABLE" | |||
| #define APP_VXLAN_TUNNEL_TABLE_NAME "VXLAN_TUNNEL_TABLE" | |||
| #define APP_ACL_TABLE_NAME "APP_ACL_TABLE" | |||
| #define APP_ACL_RULE_TABLE_NAME "APP_ACL_RULE" | |||
There was a problem hiding this comment.
do we want the APP_ prefix?
There was a problem hiding this comment.
change to
#define APP_ACL_TABLE_TABLE_NAME "ACL_TABLE_TABLE"
#define APP_ACL_RULE_TABLE_NAME "ACL_RULE_TABLE"
|
retest this please |
1 similar comment
|
retest this please |
|
@stcheng Sure , will correct it soon. |
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
|
|
I see. I think CFG_ACL_TABLE_NAME is not correct. I'll discuss internally and get back. |
|
@stcheng, do you still have concern? |
|
@shine4chen I have fixed the |
|
by the way, could you add the link to the design for adding these two tables? |
|
@stcheng This is the Appdb-acl-table definition. I will change |
Signed-off-by: shine.chen <shine.chen@nephosinc.com>
|
may i ask which application is writing to these two tables? what's the different purposes for having both configuration ACL table and application ACL table? |
|
Currently MCLAG apps will use these two acl table to dynamically install/uninstall acl rule for traffic isolation. Generally the static configured acl rules user defines will be put on cfg table. The dynamic acl rules apps defines will be put on app table. @stcheng |
|
Thanks for the response! |
Signed-off-by: shine.chen shine.chen@nephosinc.com