Fix test_vnet_orch_4 test case for vnet pytest. #1043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
previously approved these changes
Sep 3, 2019
|
can you re-enable this vnet test? |
prsunny
previously approved these changes
Sep 3, 2019
…o iris00522-vnet_test
Signed-off-by: Guohan Lu <gulv@microsoft.com>
|
according to the vstest, the test is still failing. |
|
I test test_vnet_orch_4 pass when I modify the Ethernet port from Ethernet60 to Ethernet6. |
|
retest this please |
1 similar comment
|
retest this please |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
As part of the migration from Python 2 to Python 3, this PR ensures that all Python files in sonic-utilities are Python 3-compliant, and work with both Python 2 and Python 3. Once this is merged, we can begin building a Python 3-based version of the sonic-utilities package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
modify "100.100.2.1/24" to "100.100.2.1/32" for test_vnet_orch_4 test case.
Why I did it
I trace the code, the prefix set to "100.100.2.1/32" when it create the vnet route.
create_vnet_routes(dvs, "100.100.2.1/32", 'Vnet3002', 'fd:2::34', "00:12:34:56:78:9A")
vnet_obj.check_vnet_routes(dvs, 'Vnet3002', 'fd:2::34', tunnel_name, "00:12:34:56:78:9A")
the delete prefix para should set to 100.100.2.1/32, not 100.100.2.1/24.
How I verified it
test by unittest.
Details if related