Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[utilities] Create utility classes for interacting with flex counters #1093

Merged
merged 8 commits into from
Nov 13, 2019
Merged

[utilities] Create utility classes for interacting with flex counters #1093

merged 8 commits into from
Nov 13, 2019

Conversation

daall
Copy link
Contributor

@daall daall commented Oct 12, 2019

[utilities] Create utility classes for interacting with flex counters

  • Adds utility classes for interacting with flex counters
  • Updates makefiles to support new utilities

Signed-off-by: Danny Allen daall@microsoft.com

Details if related
Related to/spun off from: #1075

@daall
[utilities] Create utility classes for interacting with flex counters
e3ce90f 
- Adds utility classes for interacting with flex counters
- Updates makefiles to support new utilities

Signed-off-by: Danny Allen <daall@microsoft.com>
@daall daall requested review from wendani and prsunny October 12, 2019 02:22
@daall daall self-assigned this Oct 12, 2019
@daall daall mentioned this pull request Oct 12, 2019
Merged
@lguohan
Copy link
Contributor

lguohan commented Oct 30, 2019

are you planning to leverage this flex counter manager class for other places using flex counter?

@daall
Copy link
Contributor Author

daall commented Oct 30, 2019

are you planning to leverage this flex counter manager class for other places using flex counter?

That's my goal, yes. Eventually I would want to refactor other daemons like the pfcorch and portsorch to use FlexCounterManager instead of re-implementing the same redis messaging schemes. To do that I'll have to extend the functionality to support plugins and such, but I wanted to limit the scope to features needed for the debug counters for this initial PR.

@daall
Copy link
Contributor Author

daall commented Oct 30, 2019

retest this please

qiluo-msft
qiluo-msft reviewed Oct 30, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented

lguohan
lguohan approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@lguohan lguohan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i am good, watch others' comments.

@daall
Copy link
Contributor Author

daall commented Nov 5, 2019

retest this please

@daall daall requested a review from yxieca November 11, 2019 23:06
@yxieca
Copy link
Contributor

yxieca commented Nov 12, 2019

Noticed some coding style issue. I think the reference type is usually declared in the format of "type& var" instead of "type &var", especially when var is the only variable defined.

Am I too old school? :-)

@yxieca yxieca self-requested a review November 12, 2019 16:33
@daall
Copy link
Contributor Author

daall commented Nov 13, 2019

retest this please

@daall
Copy link
Contributor Author

daall commented Nov 13, 2019

retest this please

@yxieca yxieca merged commit c7d8c2b into sonic-net:master Nov 13, 2019
@daall daall deleted the flex_counter_module branch December 18, 2019 01:37
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@richardyu-ms
Upgrade SAI to latest for building in bullseye (sonic-net#1093)
cac90d7 
Upgrade SAI submodule to support build saithrift with python 3.9 in bullseye

Signed-off-by: richardyu-ms <richard.yu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yxieca yxieca yxieca approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@lguohan lguohan lguohan approved these changes

@wendani wendani Awaiting requested review from wendani

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

Assignees

@daall daall

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daall @lguohan @yxieca @qiluo-msft