[qosorch] Update QoS scheduler params for shaping features #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add shaping meter_type field to SCHEDULER_TABLE * Add scheduler reference field to PORT_QOS_MAP table for port level shaping * Refer to corresponding design document for more details: sonic-net/SONiC#535 Signed-off-by: Michael Li <michael.li@broadcom.com>
|
@neethajohn, do you have any questions on the PR that I can help answer? |
neethajohn
reviewed
Jun 16, 2020
|
I don't see any testcases under swss/tests. As per the description, the testcases in HLD have been executed. Where are those testcases? |
Shaping test cases were developed using spytest. These test cases are being upstreamed by the Broadcom spytest team. Note that spytest makes use of TGENs to allow testing of datapath shaping function. |
neethajohn
approved these changes
Jun 17, 2020
|
@neethajohn Thanks for approving. Can you also review and approve the corresponding HLD doc? sonic-net/SONiC#535 |
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
Sflow docker is newly added and this needs to be stopped during fast-reboot. Otherwise sflowmgrd in sflow docker is accessing database service after is stopped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Why I did it
Update the shaping feature to reflect the corresponding QoS scheduling and shaping design doc: - sonic-net/SONiC#535
How I verified it
See test cases executed in the QoS scheduling and shaping design doc
Signed-off-by: Michael Li michael.li@broadcom.com