[Vlan]: Added SWSS support to handle new vlan cli OPTIONAL command #1329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lan type - data/mananagement/control). PR : sonic-net/sonic-utilities#956 Purpose is to identify the vlan type. This is optional configuration. If not set, it will be treated as regular ("data") vlan (current behavior). Note: SAI PR is separately raised and not merged. Meanwhile, we have hard-coded the values. This can be fixed once SAI PR is merged. Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
prsunny
requested changes
Jun 22, 2020
orchagent/portsorch.cpp
Outdated
| * 2 = control | ||
| * Change this code once attribute and enums introduced in saivlan.h | ||
| * */ | ||
| if(vlan_type != "") |
There was a problem hiding this comment.
Add a space after if and all cases down.
| * */ | ||
| if(vlan_type != "") | ||
| { | ||
| attr.id = SAI_VLAN_ATTR_META_DATA; |
There was a problem hiding this comment.
What are the attributes here? Do you have a pointer to SAI proposal?. If it is not yet approved in SAI community, it will be too early for this changes.
There was a problem hiding this comment.
SAI proposal can be found in PR, opencomputeproject/SAI#1097
Note these changes will not impact current behavior and the new commands introduced are OPTIONAL.
…lan type - data/mananagement/control). PR : sonic-net/sonic-utilities#956 Purpose is to identify the vlan type. This is optional configuration. If not set, it will be treated as regular ("data") vlan (current behavior). Note: SAI PR is separately raised and not merged. Meanwhile, we have hard-coded the values. This can be fixed once SAI PR is merged. Signed-off-by: Rajkumar Pennadam Ramamoorthy <rpennadamram@marvell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vlan type - data/mananagement/control
PR : sonic-net/sonic-utilities#956
Purpose is to identify the vlan type. This is optional configuration.
If not set, it will be treated as regular ("data") vlan (current behavior).
Note: SAI PR is separately raised and not merged.
Meanwhile, we have hard-coded the values. This can be fixed once SAI PR is merged.
Signed-off-by: Rajkumar Pennadam Ramamoorthy rpennadamram@marvell.com
What I did
Added SWSS support for new vlan enhancement. type - management/control
Why I did it
We have a use-case to differentiate managament and control traffic from regular data-traffic in data path.
How I verified it
configure the command from cli. Check CONFIG_DB,APP_DB and ASIC_DB for "vlan_type" value.
Details if related
Details of CLI command can be found in PR, sonic-net/sonic-utilities#956