[sub intf] ecmp hardware convergence acceleration at parent port oper status changes #1492
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Take sub port interface into ecmp acceleration account when a next hop object goes through a local sub port interface.
References:
Why I did it
Enhance sub port interface feature out of the responsibility as a designer.
How I verified it
vs test:
test_sub_port_intf_nhg_accel
Create multi-next-hop route entry. Next hop object goes through a local sub port interface. Bring oper status down parent port of a next hop object, and verify that the # of next hop group members changes correctly accordingly.
Before the change, all four sub test cases fail:
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks
Test case to mimic the race described in #579 between a parent port oper status down event and buffered neigh, ecmp route entry events:
Create sub port interface. Bring parent port oper status down. Mimic buffered neigh event by creating next hop object that goes through a sub port interface. Mimic buffered route entry event by creating a multi-next-hop route entry. Verify the # of next hop group members created. Specifically, next hop group member is not created on next hop object that goes through a sub port interface whose parent port is oper status down.
Before the change, all four sub test cases fail:
Details if related
Contains and thus after #1479