[vog/systemlag] Voq lagid allocator #1603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@judyjoseph - could you please review the PR, thanks. |
judyjoseph
reviewed
Feb 9, 2021
judyjoseph
reviewed
Feb 9, 2021
judyjoseph
reviewed
Feb 9, 2021
judyjoseph
reviewed
Feb 9, 2021
judyjoseph
reviewed
Feb 9, 2021
judyjoseph
reviewed
Feb 9, 2021
judyjoseph
reviewed
Feb 9, 2021
added 3 commits
February 10, 2021 10:51
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Class for lag id allocation in atomic fashion. The LAG ID is allocated from central chassis app db. A lua script loaded in the redis at the time of lag allocator instantiaion ensures allocation unqiue lag id when multiple clients requests for lag id simultaneously. System wide unique lag id is used for system lag in VOQ based switches.
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Changes to fix code review comments. The lua script evaluation is not passed with keys. The keys for the required data are internally hardcoded in the script itself.
Signed-off-by: vedganes <vedavinayagam.ganesan@nokia.com> Typos fixed. Redundant redis set call is removed.
vganesan-nokia
force-pushed
the
voq-lagid-allocator
branch
from
77b5caa
to
8688425
Compare
|
retest this please |
|
retest vs please |
1 similar comment
|
retest vs please |
|
/AzurePipelines run |
|
Commenter does not have sufficient privileges for PR 1603 in repo Azure/sonic-swss |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
retest this please |
|
retest vs please |
1 similar comment
|
retest vs please |
judyjoseph
reviewed
Mar 4, 2021
|
retest vs please |
|
retest this please |
|
retest vs please |
1 similar comment
|
retest vs please |
|
@judyjoseph, thanks for starting the Azurepipeline runs and your approval. I tried to restart the vs test. It seems "retest vs please" has not started the vs test. Would you please help to start the vs test? |
|
vs tests it not required anymore, Azure Pipeline run is good enough. I will merge it, |
o.k. thanks @judyjoseph. The system lag functionality PR (#1605) depends on this PR to build successfully. |
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-swss
that referenced
this pull request
Oct 5, 2021
What I did Defined class for lag id allocator and added lua script for allocating/freeing lag id in atomic fashion Why I did it For portchannels in VOQ based chassis systems we need unique lag id across the system. The lag id (aka system port aggreggator id) is allocated during portchannel creation. The changes are for a class for lag id allocation in atomic fashion. The LAG ID is allocated from central chassis app db. A lua script loaded in the redis at the time of lag id allocator instantiation ensures allocating unique lag id when multiple clients requests for lag id simultaneously. Ref: VOQ LAG HLD PR: sonic-net/SONiC#697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Defined class for lag id allocator and added lua script for allocating/freeing lag id in atomic fashion
Why I did it
For portchannels in VOQ based chassis systems we need unique lag id across
the system. The lag id (aka system port aggreggator id) is allocated during portchannel
creation. The changes are for a class for lag id allocation in atomic fashion. The LAG ID is allocated
from central chassis app db. A lua script loaded in the redis at the
time of lag id allocator instantiation ensures allocating unique lag id when
multiple clients requests for lag id simultaneously.
Ref: VOQ LAG HLD PR: sonic-net/SONiC#697
How I verified it
Details if related
Note: This PR is dependent on sonic-swss-common PR sonic-net/sonic-swss-common#447