Vlan status notifier #1730
Open
Vlan status notifier #1730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 047841e.
- Invoke flush Fdb entries per port/vlan - Instead of maintaining the vlan-members inside Port structure, added a new portVlanmap for vlan members. /* Performance issue are seen during mac event processing with large number of vlans on a * port. Large data should not be added to port structure. */ - created a portOidToName map to improve performace - delay lag delete until bridge port is deleted - delay bridge port removal until all asociated fdb entries are removed. delete bridge port from portsorch instead of fdborch
- Maintain a count in orchagent VLAN strcuture indicating the number of VLAN members in UP state. - Send VLAn UP/DOWN to Vlanmgr either when the first VLAN member comes up or the last VLAN member goes down. - Vlanmgr will update VLAN admin state in kernel based on notification received from orchagent.
|
This pull request introduces 1 alert when merging 34818ee into ee7a735 - view on LGTM.com new alerts:
|
|
Please explain what is the impact if the Vlan interface is staying up?. Also what are the config changes to SAI/ASIC during this. |
This reverts commit 9ba9213.
|
This pull request introduces 1 alert when merging 502b536 into 295061c - view on LGTM.com new alerts:
|
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
#### What I did fix error log variable print sequence, otherwise it is confusable #### How I did it change the varible print sequence #### New command output (if the output of a command-line utility has changed) before keepalive-interval setting: ``` root@sonic:/home/admin# config mclag 1 keepalive-interval 30 MCLAG Keepalive:15 Session_timeout:30 values not satisfying session_timeout >= (3 * KA) ``` after fixing: ``` root@sonic:/home/admin# config mclag 1 keepalive-interval 30 MCLAG Keepalive:30 Session_timeout:15 values not satisfying session_timeout >= (3 * KA) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
- Maintain a count in orchagent VLAN strcuture indicating the number
of VLAN members in UP state.
- Send VLAn UP/DOWN to Vlanmgr either when the first VLAN member
comes up or the last VLAN member goes down.
- Vlanmgr will update VLAN admin state in kernel based on notification
received from orchagent.
Why I did it
Vlan routing interface is UP even though the corresponding port-channel on which that vlan routing interface configured is DOWN.
How I verified it
Manual tests
Details if related