Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vstest/acl table] Fix ports field in acl table creation #2030

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[vstest/acl table] Fix ports field in acl table creation #2030

wants to merge 1 commit into from

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Nov 14, 2021

Signed-off-by: Wenda Ni wonda.ni@gmail.com

What I did

Why I did it
Be consistent with dvs_acl.create_acl_table

        table_attrs = { 
            "policy_desc": table_name,
            "type": table_type,
            "ports@": ",".join(ports)
        }

How I verified it
vs test

Details if related

@wendani
Fix acl table field ports
3df622f 
Signed-off-by: Wenda Ni <wonda.ni@gmail.com>
@wendani wendani requested a review from prsunny as a code owner November 14, 2021 09:50
@prsunny prsunny requested a review from bingwang-ms November 16, 2021 02:39
@prsunny
Copy link
Collaborator

prsunny commented Nov 16, 2021

@wendani , does that mean old config should be failing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@bingwang-ms bingwang-ms Awaiting requested review from bingwang-ms

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wendani @prsunny