Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve VS test stability #2173

Closed
wants to merge 16 commits into from

Conversation

theasianpianist
Copy link
Contributor

What I did

Why I did it

How I verified it

Details if related

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@theasianpianist theasianpianist requested a review from prsunny as a code owner March 8, 2022 00:43
@theasianpianist theasianpianist marked this pull request as draft March 8, 2022 00:45
@theasianpianist theasianpianist marked this pull request as ready for review March 8, 2022 00:45
@theasianpianist
Copy link
Contributor Author

/Azp run

@azure-pipelines
Copy link

Azure Pipelines failed to run 1 pipeline(s).

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@prsunny prsunny requested a review from xumia March 8, 2022 01:38
@theasianpianist theasianpianist force-pushed the vs-test-fix branch 2 times, most recently from 7eadff7 to 8c67036 Compare March 8, 2022 02:36
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@theasianpianist theasianpianist force-pushed the vs-test-fix branch 3 times, most recently from d153ae5 to 709262c Compare March 8, 2022 19:30
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@theasianpianist theasianpianist force-pushed the vs-test-fix branch 3 times, most recently from 7d463d3 to 1871739 Compare March 8, 2022 23:37
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
@theasianpianist
Copy link
Contributor Author

/Azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -75,26 +81,6 @@ jobs:
libteam5 \
libteamdctl0
displayName: "Install dependencies"
- task: DownloadPipelineArtifact@2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, let's bring this back as we would need to download from respective repo.

artifact_name: sonic-swss
swss_common_artifact_name: sonic-swss-common.amd64.ubuntu20_04
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this.

Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Signed-off-by: Lawrence Lee <lawlee@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants