[muxorch] Adding case for maintaining current state #2280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
May 18, 2022
prsunny
previously approved these changes
May 18, 2022
|
@Ndancejic , seems like there are some VS failures due to the change: |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 2280 in repo sonic-net/sonic-swss |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Ndancejic
force-pushed
the
mux_states
branch
from
6212935 to
6f5235b
Compare
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
What I did: Added a case where if current and previous Mux states are the same, post a log entry that acknowleges this change and returns without doing anything. Why I did it: Valid state changes such as active-active and standby-standby were causing error logs How I tested it: added a case to check active-active state change and standby-standby state change. Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
Signed-off-by: Nikola Dancejic <ndancejic@microsoft.com>
prsunny
approved these changes
Nov 3, 2022
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
pushed a commit
that referenced
this pull request
Dec 7, 2022
* [muxorch] Adding case for maintaining current state What I did: Added a case where if current and previous Mux states are the same, post a log entry that acknowleges this change and returns without doing anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Added a case where if current and previous Mux states
are the same, post a log entry that acknowleges this
change and returns without doing anything.
Why I did it:
Valid state changes such as active-active and
standby-standby were causing error logs
How I tested it:
added a case to check active-active state change
and standby-standby state change.
Signed-off-by: Nikola Dancejic ndancejic@microsoft.com