Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Purge package sonic-db-cli which depends on libswsscommon #2308

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Jun 2, 2022

What I did
Purge package sonic-db-cli which depends on libswsscommon

Why I did it
Since sonic-db-cli depends on libswsscommon, we could not simply only purge libswsscommon, so we purge both together.

The build error is as below

Step 8/22 : RUN dpkg --purge libswsscommon
 ---> Running in 0297ee02869f
dpkg: dependency problems prevent removal of libswsscommon:
 sonic-db-cli depends on libswsscommon.

How I verified it

Details if related

@theasianpianist
Copy link
Contributor

Do we also need to re-install sonic-db-cli with the other packages so that it's available in the DVS?

@lguohan
Copy link
Contributor

lguohan commented Jun 2, 2022

i guess we should. but now sure if vstest is using sonic-db-cli?

@theasianpianist
Copy link
Contributor

i guess we should. but now sure if vstest is using sonic-db-cli?

Don't think the tests are using it, but it may be useful for manual debugging if someone needs to download a DVS image from AZP

@prsunny
Copy link
Collaborator

prsunny commented Jun 3, 2022

Following VS test failures on WB is being analyzed and not caused by this change.

test_warm_reboot.py::TestWarmReboot::test_swss_neighbor_syncup FAILED    [ 96%]
test_warm_reboot.py::TestWarmReboot::test_OrchagentWarmRestartReadyCheck FAILED [ 96%]
test_warm_reboot.py::TestWarmReboot::test_swss_port_state_syncup FAILED  [ 96%]
test_warm_reboot.py::TestWarmReboot::test_routing_WarmRestart FAILED     [ 96%]

Inorder to unblock the rest of the PRs, need to force-merge this.

@qiluo-msft qiluo-msft merged commit 05d19ea into sonic-net:master Jun 3, 2022
@qiluo-msft qiluo-msft deleted the qiluo/purgecli branch June 3, 2022 03:58
preetham-singh pushed a commit to preetham-singh/sonic-swss that referenced this pull request Aug 6, 2022
…2308)

**What I did**
Purge package sonic-db-cli which depends on libswsscommon

**Why I did it**
Since sonic-db-cli depends on libswsscommon, we could not simply only purge libswsscommon, so we purge both together.
yxieca pushed a commit that referenced this pull request Aug 8, 2022
**What I did**
Purge package sonic-db-cli which depends on libswsscommon

**Why I did it**
Since sonic-db-cli depends on libswsscommon, we could not simply only purge libswsscommon, so we purge both together.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants