Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HOSTIF] Keep VLAN tag if subport is added. #2487

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[HOSTIF] Keep VLAN tag if subport is added. #2487

wants to merge 1 commit into from

Conversation

iMasaruOki
Copy link

@iMasaruOki iMasaruOki commented Oct 11, 2022 •
edited
Loading

Signed-off-by: Masaru OKI masaru.oki@gmail.com

What I did
Enable SAI_HOSTIF_VLAN_TAG_KEEP if subport list is not empty.

Why I did it
In original code, VLAN tag is stripped in receved packet. It is incorrect.

How I verified it

# peer linux host:
#  sudo ip link add link eth1 name eth1.100 type vlan id 100; sudo ip link set eth1.100
#  sudo ip addr 192.168.100.2/24 dev eth1.100
#  sudo ip link set eth1.100 up
sudo confgi interface ip add Ethernet16.100 192.168.100.1/24
ping 192.168.100.2

Details if related

@iMasaruOki iMasaruOki requested a review from prsunny as a code owner October 11, 2022 18:56
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 11, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: iMasaruOki / name: Masaru OKI (7dd29b8)

@iMasaruOki
Keep VLAN tag if subport is added.
7dd29b8 
Signed-off-by: Masaru OKI <masaru.oki@gmail.com>
@mssonicbld
Copy link
Collaborator

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@prsunny prsunny requested a review from dgsudharsan January 6, 2025 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@dgsudharsan dgsudharsan Awaiting requested review from dgsudharsan

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iMasaruOki @mssonicbld