Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore preemphasis when AN is transitioned from ON to OFF #3131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Restore preemphasis when AN is transitioned from ON to OFF #3131

wants to merge 1 commit into from

Conversation

PJHsieh
Copy link

@PJHsieh PJHsieh commented May 3, 2024 •
edited
Loading

What I did
Restore preemphasis when AN is transitioned from ON to OFF

Why I did it
In certain switches, link training is enabled along with auto-negotiation(AN) enabled. In this case, the preemphasis settings may be changed due to the presence of enabled link training. Therefore, it's essential to restore the preemphasis value when auto-negotiation transitions from ON to OFF.

How I verified it

  1. Check the current pre-emphasis value P1 by bcmcmd.
  2. Enable AN on a port, make sure the port is up and the pre-emphasis is changed to P2 by link-training.
  3. Disable AN on the testing port, check the pre-emphasis value is restored to P1 by bcmcmd.

Details if related

@PJHsieh
Restore preemphasis when AN is transitioned from ON to OFF
567e4ca 
In certain switches, link training is enabled along with auto-negotiation(AN)
enabled. In this case, the preemphasis settings may be changed due to
the presence of enabled link training. Therefore, it's essential to restore the
preemphasis value when auto-negotiation transitions from ON to OFF.
@PJHsieh PJHsieh requested a review from prsunny as a code owner May 3, 2024 03:36
@PJHsieh
Copy link
Author

PJHsieh commented May 3, 2024

Hi, @prsunny ,

Please review this PR, thank you.

@prsunny prsunny requested review from dgsudharsan and prgeor May 3, 2024 16:18
@PJHsieh PJHsieh mentioned this pull request Jul 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgsudharsan dgsudharsan dgsudharsan approved these changes

@prsunny prsunny Awaiting requested review from prsunny prsunny is a code owner

@prgeor prgeor Awaiting requested review from prgeor

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PJHsieh @dgsudharsan