Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub port interface implementation #969

Merged
merged 57 commits into from
Nov 8, 2019
Merged

Sub port interface implementation #969

merged 57 commits into from
Nov 8, 2019

Conversation

wendani
Copy link
Contributor

@wendani wendani commented Jul 10, 2019 •
edited
Loading

What I did
Implement HLD: sonic-net/SONiC#420

IntfMgrd:
Listen to CONFIG_DB VLAN_SUB_INTERFACE table.
Process host sub port interface: create, set (admin_status), and remove using ip link and ip address system call, and update the STATE_DB
Relay the VLAN_SUB_INTERFACE table operation and field-value content to APPL_DB INTF_TABLE.

IntfOrch:
Listen to APPL_DB INTF_TABLE.
Process sub port interface on physical port: create (a Port object for sub port interface), set (admin_status), and remove.

PortsOrch:
Add member function to create a Port object for sub port interface

vs unit test:
sub port interface creation
sub port interface add IP addresses
sub port interface admin status change
sub port interface remove IP addresses
sub port interface removal

Why I did it

How I verified it
Tested on mlnx dut

Details if related
Depend on:
sonic-net/sonic-swss-common#284

ERR swss#orchagent: :- doTask: sub interface: Ethernet64.10
ERR swss#orchagent: :- addSubPort: sub interface Ethernet64.10: parent interface Ethernet64, vlan 10
INFO syncd#supervisord: syncd Jun 29 03:54:37 NOTICE  SAI_RIF: mlnx_sai_rif.c[851]- mlnx_create_router_interface: Created rif rif idx 4
NOTICE swss#orchagent: :- addRouterIntfs: Create router interface Ethernet64.10 MTU 9100
ERR swss#orchagent: :- doTask: sub interface: Ethernet64.10
INFO syncd#supervisord: syncd Jun 29 03:54:37 NOTICE  SAI_RIF: mlnx_sai_rif.c[548]- mlnx_create_router_interface: Create rif, #0 VIRTUAL_ROUTER_ID=VIRTUAL_ROUTER,(0:0),0,0000,0 #1 SRC_MAC_ADDRESS=[7c:fe:90:f9:3e:80] #2 TYPE=PORT #3 PORT_ID=PORT,(0:0),13100,0000,0 #4 MTU=9100
NOTICE swss#orchagent: :- addSubnetRoute: Create subnet route to 192.168.0.1/21 from Ethernet64.10
NOTICE swss#orchagent: :- addIp2MeRoute: Create IP2me route ip:192.168.0.1

ERR swss#orchagent: :- doTask: sub interface: Ethernet64.10
NOTICE swss#orchagent: :- removeSubnetRoute: Remove subnet route to 192.168.0.1/21 from Ethernet64.10
NOTICE swss#orchagent: :- removeIp2MeRoute: Remove packet action trap route ip:192.168.0.1
ERR syncd#syncd: :- setRifCounterList: Router interface oid:0x7c100000006 does not have supported counters
NOTICE swss#orchagent: :- removeRouterIntfs: Remove router interface for port Ethernet64.10
ERR swss#orchagent: :- removeSubPort: Sub interface Ethernet64.10 Port object removed successfully
INFO syncd#supervisord: syncd Jul 01 16:58:28 NOTICE  SAI_ROUTE: mlnx_sai_route.c[369]- mlnx_remove_route: Remove route route 192.168.0.0 255.255.248.0
INFO syncd#supervisord: syncd Jul 01 16:58:28 NOTICE  SAI_ROUTE: mlnx_sai_route.c[369]- mlnx_remove_route: Remove route route 192.168.0.1 255.255.255.255
INFO syncd#supervisord: syncd Jul 01 16:58:28 NOTICE  SAI_RIF: mlnx_sai_rif.c[893]- mlnx_remove_router_interface: Remove rif rif idx 31

    "VLAN_SUB_INTERFACE": {
        "Ethernet64.10": {
            "admin_status" : "up"
        },
        "Ethernet64.10|10.0.0.33/31": {},
        "Ethernet64.10|FC00::41/126": {}
    },

127.0.0.1:6379[1]> hgetall "ASIC_STATE:SAI_OBJECT_TYPE_ROUTER_INTERFACE:oid:0x60000000005be"
 1) "SAI_ROUTER_INTERFACE_ATTR_VIRTUAL_ROUTER_ID"
 2) "oid:0x3000000000022"
 3) "SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS"
 4) "02:42:AC:11:00:02"
 5) "SAI_ROUTER_INTERFACE_ATTR_TYPE"
 6) "SAI_ROUTER_INTERFACE_TYPE_SUB_PORT"
 7) "SAI_ROUTER_INTERFACE_ATTR_PORT_ID"
 8) "oid:0x1000000000012"
 9) "SAI_ROUTER_INTERFACE_ATTR_OUTER_VLAN_ID"
10) "10"
11) "SAI_ROUTER_INTERFACE_ATTR_ADMIN_V4_STATE"
12) "true"
13) "SAI_ROUTER_INTERFACE_ATTR_ADMIN_V6_STATE"
14) "true"
15) "SAI_ROUTER_INTERFACE_ATTR_MTU"
16) "9100"

127.0.0.1:6379[1]> keys *ROUTE_ENTRY*
1) "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:{\"dest\":\"fc00::40/126\",\"switch_id\":\"oid:0x21000000000000\",\"vr\":\"oid:0x3000000000022\"}"
3) "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:{\"dest\":\"fc00::41/128\",\"switch_id\":\"oid:0x21000000000000\",\"vr\":\"oid:0x3000000000022\"}"
4) "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:{\"dest\":\"10.0.0.32/31\",\"switch_id\":\"oid:0x21000000000000\",\"vr\":\"oid:0x3000000000022\"}"
6) "ASIC_STATE:SAI_OBJECT_TYPE_ROUTE_ENTRY:{\"dest\":\"10.0.0.33/32\",\"switch_id\":\"oid:0x21000000000000\",\"vr\":\"oid:0x3000000000022\"}"

$ show bgp sum               

IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12910
RIB entries 13015, using 2034 KiB of memory
Peers 32, using 661 KiB of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
10.0.0.33       4      64001       0       0        0    0    0    never      Connect


IPv6 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12909
RIB entries 13013, using 2033 KiB of memory
Peers 32, using 661 KiB of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
fc00::42        4      64001       0       0        0    0    0    never       Active

Scenario 1:

Packets egress out of front-panel port from control plane Linux. What is received at ptf interface tcpdump -ni eth16 -vxe

13:19:48.405329 7c:fe:90:f9:3e:80 > ff:ff:ff:ff:ff:ff, ethertype 802.1Q (0x8100), length 60: vlan 10, p 0, ethertype ARP, Ethernet (len 6), IPv4 (len 4), Request who-has 10.0.0.33 tell 10.0.0.32, length 42
        0x0000:  0001 0800 0604 0001 7cfe 90f9 3e80 0a00
        0x0010:  0020 0000 0000 0000 0a00 0021 0000 0000
        0x0020:  0000 0000 0000 0000 0000

13:20:25.328725 7c:fe:90:f9:3e:80 > 33:33:ff:00:00:42, ethertype 802.1Q (0x8100), length 90: vlan 10, p 0, ethertype IPv6, (hlim 255, next-header ICMPv6 (58) payload length: 32) fc00::41 > ff02::1:ff00:42: [icmp6 sum ok] ICMP6, neighbor solicitation, length 32, who has fc00::42
          source link-address option (1), length 8 (1): 7c:fe:90:f9:3e:80
        0x0000:  6000 0000 0020 3aff fc00 0000 0000 0000
        0x0010:  0000 0000 0000 0041 ff02 0000 0000 0000
        0x0020:  0000 0001 ff00 0042 8700 3460 0000 0000
        0x0030:  fc00 0000 0000 0000 0000 0000 0000 0042
        0x0040:  0101 7cfe 90f9 3e80

Scenario 2:

Send ARP request from ptf

pkt = Ether(dst="ff:ff:ff:ff:ff:ff",src="be:58:9c:69:18:c3")/Dot1Q(prio= 3, vlan=10)/ARP(hwsrc="be:58:9c:69:18:c3",psrc="10.0.0.33",pdst="10.0.0.32")
sendp(pkt,iface="eth16", count=10)

What is received and replied at host sub port interface on DUT control plane Linux sudo tcpdump -ni Ethernet64.10 -vxe. Packets received and sent from sub port interface is stripped of 802.1q tag.

23:41:56.988568 be:58:9c:69:18:c3 > ff:ff:ff:ff:ff:ff, ethertype ARP (0x0806), length 56: Ethernet (len 6), IPv4 (len 4), Request who-has 10.0.0.32 tell 10.0.0.33, length 42
        0x0000:  0001 0800 0604 0001 be58 9c69 18c3 0a00
        0x0010:  0021 0000 0000 0000 0a00 0020 0000 0000
        0x0020:  0000 0000 0000 8c75 e7c5
23:41:56.988591 7c:fe:90:f9:3e:80 > be:58:9c:69:18:c3, ethertype ARP (0x0806), length 42: Ethernet (len 6), IPv4 (len 4), Reply 10.0.0.32 is-at 7c:fe:90:f9:3e:80, length 28
        0x0000:  0001 0800 0604 0002 7cfe 90f9 3e80 0a00
        0x0010:  0020 be58 9c69 18c3 0a00 0021

$ show arp
Address        MacAddress         Iface          Vlan
-------------  -----------------  -------------  ------
10.0.0.33      be:58:9c:69:18:c3  Ethernet64.10  -

Packets ptf sees tcpdump -ni eth16 -vxe. They are 802.1q tagged.

18:36:43.072422 be:58:9c:69:18:c3 > ff:ff:ff:ff:ff:ff, ethertype 802.1Q (0x8100), length 46: vlan 10, p 3, ethertype ARP, Ethernet (len 6), IPv4 (len 4), Request who-has 10.0.0.32 tell 10.0.0.33, length 28
        0x0000:  0001 0800 0604 0001 be58 9c69 18c3 0a00
        0x0010:  0021 0000 0000 0000 0a00 0020
18:36:43.072612 7c:fe:90:f9:3e:80 > be:58:9c:69:18:c3, ethertype 802.1Q (0x8100), length 60: vlan 10, p 0, ethertype ARP, Ethernet (len 6), IPv4 (len 4), Reply 10.0.0.32 is-at 7c:fe:90:f9:3e:80, length 42
        0x0000:  0001 0800 0604 0002 7cfe 90f9 3e80 0a00
        0x0010:  0020 be58 9c69 18c3 0a00 0021 0000 0000
        0x0020:  0000 0000 0000 0000 0000

vs test:

localadmin@wenni-vm0:~/sonic-buildimage/src/sonic-swss/tests$ sudo pytest -s test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_creation --dvsname=vs
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.7.0, pluggy-0.6.0
rootdir: /home/localadmin/190607/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 1 item                                                                                                                                                                         

test_sub_port_intf.py remove extra link dummy
.                                                                                                                                                            [100%]

=============================================================================== 1 passed in 34.97 seconds ================================================================================

localadmin@wenni-vm0:~/sonic-buildimage/src/sonic-swss/tests$ sudo pytest -s test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_add_ip_addrs --dvsname=vs
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.7.0, pluggy-0.6.0
rootdir: /home/localadmin/190607/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 1 item                                                                                                                                                                         

test_sub_port_intf.py remove extra link dummy
.                                                                                                                                                            [100%]

=============================================================================== 1 passed in 38.59 seconds ====================================================================

localadmin@wenni-vm0:~/sonic-buildimage/src/sonic-swss/tests$ sudo pytest -s test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_admin_status_change --dvsname=vs
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.7.0, pluggy-0.6.0
rootdir: /home/localadmin/190607/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 1 item                                                                                                                                                                         

test_sub_port_intf.py remove extra link dummy
.                                                                                                                                                            [100%]

=============================================================================== 1 passed in 42.09 seconds ===============================================================================

localadmin@wenni-vm0:~/sonic-buildimage/src/sonic-swss/tests$ sudo pytest -s test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_remove_ip_addrs --dvsname=vs
================================================================================== test session starts ===================================================================================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.7.0, pluggy-0.6.0
rootdir: /home/localadmin/190607/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 1 item                                                                                                                                                                         

test_sub_port_intf.py remove extra link dummy
.                                                                                                                                                            [100%]

=============================================================================== 1 passed in 41.26 seconds ================================================================================

localadmin@wenni-vm0:~/sonic-buildimage/src/sonic-swss/tests$ sudo pytest -s test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_removal --dvsname=vs
============================================================= test session starts ==============================================================
platform linux2 -- Python 2.7.12, pytest-3.3.0, py-1.7.0, pluggy-0.6.0
rootdir: /home/localadmin/190607/sonic-buildimage/src/sonic-swss/tests, inifile:
collected 1 item                                                                                                                               

test_sub_port_intf.py remove extra link dummy
.                                                                                                                  [100%]

========================================================== 1 passed in 41.99 seconds ===========================================================

Test on mlnx dut

master d5af096

ii  mlnx-sai                   1.mlnx.SAIRel1.15.1-ptf-rif-vlan-fix amd64        contains SAI implementation for Mellanox hardware

Before applying VLAN_SUB_INTERFACE config to CONFIG_DB

admin@str-msn2700-22:~$ show bgp sum

IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12910
RIB entries 13015, using 2339 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
...
10.0.0.29       4      65200    3617    3800        0    0    0 00:20:33         6402
10.0.0.31       4      65200    3617    3800        0    0    0 00:20:33         6402
10.0.0.33       4      64001       0       0        0    0    0    never       Active
10.0.0.35       4      64002     417    3800        0    0    0 00:20:33            6
10.0.0.37       4      64003     418    3800        0    0    0 00:20:34            7
...

Total number of neighbors 32

IPv6 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12909
RIB entries 13013, using 2338 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
...
fc00::3a        4      65200    3618    3967        0    0    0 00:20:33         6402
fc00::3e        4      65200    3618    3967        0    0    0 00:20:33         6402
fc00::42        4      64001       0       0        0    0    0    never       Active
fc00::46        4      64002     418    3967        0    0    0 00:20:33            6
fc00::4a        4      64003     418    3967        0    0    0 00:20:34            6
...

Total number of neighbors 32

Apply VLAN_SUB_INTERFACE config to CONFIG_DB

    "VLAN_SUB_INTERFACE": {
        "Ethernet64.10": {
            "admin_status" : "up"
        },
        "Ethernet64.10|10.0.0.32/31": {},
        "Ethernet64.10|FC00::41/126": {}
    },  

admin@str-msn2700-22:~$ show bgp sum

IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12917
RIB entries 13027, using 2341 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
10.0.0.1        4      65200    3475    5442        0    0    0 00:13:30         6402
10.0.0.3        4      65200    3475    5442        0    0    0 00:13:29         6402
10.0.0.5        4      65200    3475    5442        0    0    0 00:13:30         6402
10.0.0.7        4      65200    3475    5442        0    0    0 00:13:29         6402
10.0.0.9        4      65200    3475    5442        0    0    0 00:13:29         6402
10.0.0.11       4      65200    3475    5442        0    0    0 00:13:30         6402
10.0.0.13       4      65200    3475    5442        0    0    0 00:13:30         6402
10.0.0.15       4      65200    3475    5442        0    0    0 00:13:28         6402
10.0.0.17       4      65200    3475    5442        0    0    0 00:13:30         6402
10.0.0.19       4      65200    3476    5443        0    0    0 00:13:31         6402
10.0.0.21       4      65200    3475    5442        0    0    0 00:13:29         6402
10.0.0.23       4      65200    3475    5442        0    0    0 00:13:28         6402
10.0.0.25       4      65200    3475    5442        0    0    0 00:13:30         6402
10.0.0.27       4      65200    3474    5441        0    0    0 00:13:27         6402
10.0.0.29       4      65200    3475    5442        0    0    0 00:13:28         6402
10.0.0.31       4      65200    3475    5442        0    0    0 00:13:29         6402
10.0.0.33       4      64001     276    5442        0    0    0 00:13:30            7
10.0.0.35       4      64002     275    5442        0    0    0 00:13:29            6
10.0.0.37       4      64003     276    5442        0    0    0 00:13:30            7
10.0.0.39       4      64004     275    5442        0    0    0 00:13:30            6
10.0.0.41       4      64005     271    3505        0    0    0 00:13:18            6
10.0.0.43       4      64006     272    3506        0    0    0 00:13:19            6
10.0.0.45       4      64007     271    3505        0    0    0 00:13:17            6
10.0.0.47       4      64008     270    3504        0    0    0 00:13:15            6
10.0.0.49       4      64009     271    3505        0    0    0 00:13:16            6
10.0.0.51       4      64010     271    3505        0    0    0 00:13:18            6
10.0.0.53       4      64011     272    3506        0    0    0 00:13:19            6
10.0.0.55       4      64012     271    3505        0    0    0 00:13:17            6
10.0.0.57       4      64013     270    3503        0    0    0 00:13:15            6
10.0.0.59       4      64014     272    3506        0    0    0 00:13:20            6
10.0.0.61       4      64015     271    3506        0    0    0 00:13:18            6
10.0.0.63       4      64016     272    3506        0    0    0 00:13:19            6

Total number of neighbors 32

IPv6 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12915
RIB entries 13025, using 2340 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
fc00::2         4      65200    3476    4204        0    0    0 00:13:30         6402
fc00::6         4      65200    3476    4204        0    0    0 00:13:29         6402
fc00::a         4      65200    3476    4204        0    0    0 00:13:30         6402
fc00::e         4      65200    3476    4204        0    0    0 00:13:29         6402
fc00::12        4      65200    3476    4204        0    0    0 00:13:29         6402
fc00::16        4      65200    3476    4204        0    0    0 00:13:30         6402
fc00::1a        4      65200    3476    4204        0    0    0 00:13:30         6402
fc00::1e        4      65200    3476    4204        0    0    0 00:13:28         6402
fc00::22        4      65200    3476    4204        0    0    0 00:13:30         6402
fc00::26        4      65200    3477    4205        0    0    0 00:13:31         6402
fc00::2a        4      65200    3476    4204        0    0    0 00:13:29         6402
fc00::2e        4      65200    3476    4204        0    0    0 00:13:28         6402
fc00::32        4      65200    3476    4204        0    0    0 00:13:30         6402
fc00::36        4      65200    3475    4203        0    0    0 00:13:27         6402
fc00::3a        4      65200    3476    4204        0    0    0 00:13:28         6402
fc00::3e        4      65200    3476    4204        0    0    0 00:13:29         6402
fc00::42        4      64001     276    4204        0    0    0 00:13:30            6
fc00::46        4      64002     276    4204        0    0    0 00:13:29            6
fc00::4a        4      64003     276    4204        0    0    0 00:13:30            6
fc00::4e        4      64004     276    4204        0    0    0 00:13:30            6
fc00::52        4      64005     273    3519        0    0    0 00:13:19            6
fc00::56        4      64006     272    3518        0    0    0 00:13:16            6
fc00::5a        4      64007     272    3518        0    0    0 00:13:16            6
fc00::5e        4      64008     273    3519        0    0    0 00:13:20            6
fc00::62        4      64009     272    3519        0    0    0 00:13:19            6
fc00::66        4      64010     271    3517        0    0    0 00:13:14            6
fc00::6a        4      64011     272    3518        0    0    0 00:13:17            6
fc00::6e        4      64012     271    3517        0    0    0 00:13:14            6
fc00::72        4      64013     273    3519        0    0    0 00:13:19            6
fc00::76        4      64014     272    3518        0    0    0 00:13:17            6
fc00::7a        4      64015     271    3517        0    0    0 00:13:15            6
fc00::7e        4      64016     272    3518        0    0    0 00:13:17            6

Total number of neighbors 32

admin@str-msn2700-22:~$ redis-cli -n 2 hgetall "COUNTERS_RIF_NAME_MAP"
63) "Ethernet64.10"
64) "oid:0x600000000063c"

admin@str-msn2700-22:~$ redis-cli -n 1 hgetall "ASIC_STATE:SAI_OBJECT_TYPE_ROUTER_INTERFACE:oid:0x600000000063c"  
 1) "SAI_ROUTER_INTERFACE_ATTR_VIRTUAL_ROUTER_ID"
 2) "oid:0x3000000000010"
 3) "SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS"
 4) "7C:FE:90:F9:3E:80"
 5) "SAI_ROUTER_INTERFACE_ATTR_TYPE"
 6) "SAI_ROUTER_INTERFACE_TYPE_SUB_PORT"
 7) "SAI_ROUTER_INTERFACE_ATTR_PORT_ID"
 8) "oid:0x100000000014a"
 9) "SAI_ROUTER_INTERFACE_ATTR_OUTER_VLAN_ID"
10) "10"
11) "SAI_ROUTER_INTERFACE_ATTR_ADMIN_V4_STATE"
12) "true"
13) "SAI_ROUTER_INTERFACE_ATTR_ADMIN_V6_STATE"
14) "true"
15) "SAI_ROUTER_INTERFACE_ATTR_MTU"
16) "9100"

admin@str-msn2700-22:~$ redis-cli -n 6 hgetall "INTERFACE_TABLE|Ethernet64.10"
1) "vrf"
2) ""

admin@str-msn2700-22:~$ show subinterfaces status
  Sub port interface    Speed    MTU    Vlan    Admin                  Type
--------------------  -------  -----  ------  -------  --------------------
       Ethernet64.10     100G   9100      10       up  802.1q-encapsulation

admin@str-msn2700-22:~$ show subinterfaces status --verbose
Command: intfutil status subport
  Sub port interface    Speed    MTU    Vlan    Admin                  Type
--------------------  -------  -----  ------  -------  --------------------
       Ethernet64.10     100G   9100      10       up  802.1q-encapsulation

admin@str-msn2700-22:~$ sudo config interface shutdown Ethernet64.10
admin@str-msn2700-22:~$ redis-cli -n 1 hgetall "ASIC_STATE:SAI_OBJECT_TYPE_ROUTER_INTERFACE:oid:0x600000000063c"
 1) "SAI_ROUTER_INTERFACE_ATTR_VIRTUAL_ROUTER_ID"
 2) "oid:0x3000000000010"
 3) "SAI_ROUTER_INTERFACE_ATTR_SRC_MAC_ADDRESS"
 4) "7C:FE:90:F9:3E:80"
 5) "SAI_ROUTER_INTERFACE_ATTR_TYPE"
 6) "SAI_ROUTER_INTERFACE_TYPE_SUB_PORT"
 7) "SAI_ROUTER_INTERFACE_ATTR_PORT_ID"
 8) "oid:0x100000000014a"
 9) "SAI_ROUTER_INTERFACE_ATTR_OUTER_VLAN_ID"
10) "10"
11) "SAI_ROUTER_INTERFACE_ATTR_ADMIN_V4_STATE"
12) "false"
13) "SAI_ROUTER_INTERFACE_ATTR_ADMIN_V6_STATE"
14) "false"
15) "SAI_ROUTER_INTERFACE_ATTR_MTU"
16) "9100"
admin@str-msn2700-22:~$ show bgp sum

IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12924
RIB entries 13015, using 2339 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
10.0.0.1        4      65200    4541    6510        0    0    0 01:06:47         6402
10.0.0.3        4      65200    4541    6510        0    0    0 01:06:46         6402
10.0.0.5        4      65200    4541    6510        0    0    0 01:06:47         6402
10.0.0.7        4      65200    4541    6510        0    0    0 01:06:46         6402
10.0.0.9        4      65200    4540    6510        0    0    0 01:06:46         6402
10.0.0.11       4      65200    4541    6510        0    0    0 01:06:47         6402
10.0.0.13       4      65200    4541    6510        0    0    0 01:06:47         6402
10.0.0.15       4      65200    4540    6510        0    0    0 01:06:45         6402
10.0.0.17       4      65200    4541    6510        0    0    0 01:06:47         6402
10.0.0.19       4      65200    4541    6510        0    0    0 01:06:48         6402
10.0.0.21       4      65200    4540    6510        0    0    0 01:06:46         6402
10.0.0.23       4      65200    4540    6510        0    0    0 01:06:45         6402
10.0.0.25       4      65200    4541    6510        0    0    0 01:06:47         6402
10.0.0.27       4      65200    4540    6509        0    0    0 01:06:44         6402
10.0.0.29       4      65200    4541    6510        0    0    0 01:06:45         6402
10.0.0.31       4      65200    4540    6510        0    0    0 01:06:46         6402
10.0.0.33       4      64001    1338    6504        0    0    0 00:00:12       Active
10.0.0.35       4      64002    1341    6510        0    0    0 01:06:46            6
10.0.0.37       4      64003    1342    6510        0    0    0 01:06:47            7
10.0.0.39       4      64004    1341    6510        0    0    0 01:06:47            6
10.0.0.41       4      64005    1337    4573        0    0    0 01:06:35            6
10.0.0.43       4      64006    1337    4573        0    0    0 01:06:36            6
10.0.0.45       4      64007    1337    4573        0    0    0 01:06:34            6
10.0.0.47       4      64008    1336    4571        0    0    0 01:06:32            6
10.0.0.49       4      64009    1336    4572        0    0    0 01:06:33            6
10.0.0.51       4      64010    1337    4573        0    0    0 01:06:35            6
10.0.0.53       4      64011    1337    4573        0    0    0 01:06:36            6
10.0.0.55       4      64012    1336    4573        0    0    0 01:06:34            6
10.0.0.57       4      64013    1336    4571        0    0    0 01:06:32            6
10.0.0.59       4      64014    1337    4574        0    0    0 01:06:37            6
10.0.0.61       4      64015    1337    4573        0    0    0 01:06:35            6
10.0.0.63       4      64016    1337    4573        0    0    0 01:06:36            6

Total number of neighbors 32

IPv6 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12921
RIB entries 13013, using 2338 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
fc00::2         4      65200    4542    5271        0    0    0 01:06:47         6402
fc00::6         4      65200    4542    5271        0    0    0 01:06:46         6402
fc00::a         4      65200    4542    5271        0    0    0 01:06:47         6402
fc00::e         4      65200    4542    5271        0    0    0 01:06:46         6402
fc00::12        4      65200    4541    5271        0    0    0 01:06:46         6402
fc00::16        4      65200    4542    5271        0    0    0 01:06:47         6402
fc00::1a        4      65200    4542    5271        0    0    0 01:06:47         6402
fc00::1e        4      65200    4541    5271        0    0    0 01:06:45         6402
fc00::22        4      65200    4542    5271        0    0    0 01:06:47         6402
fc00::26        4      65200    4542    5271        0    0    0 01:06:48         6402
fc00::2a        4      65200    4541    5271        0    0    0 01:06:46         6402
fc00::2e        4      65200    4541    5271        0    0    0 01:06:45         6402
fc00::32        4      65200    4542    5271        0    0    0 01:06:47         6402
fc00::36        4      65200    4541    5270        0    0    0 01:06:44         6402
fc00::3a        4      65200    4541    5271        0    0    0 01:06:45         6402
fc00::3e        4      65200    4541    5271        0    0    0 01:06:46         6402
fc00::42        4      64001    1338    5266        0    0    0 00:00:11       Active
fc00::46        4      64002    1342    5271        0    0    0 01:06:46            6
fc00::4a        4      64003    1342    5271        0    0    0 01:06:47            6
fc00::4e        4      64004    1342    5271        0    0    0 01:06:47            6
fc00::52        4      64005    1338    4585        0    0    0 01:06:36            6
fc00::56        4      64006    1337    4584        0    0    0 01:06:33            6
fc00::5a        4      64007    1337    4584        0    0    0 01:06:33            6
fc00::5e        4      64008    1338    4586        0    0    0 01:06:37            6
fc00::62        4      64009    1338    4585        0    0    0 01:06:36            6
fc00::66        4      64010    1336    4584        0    0    0 01:06:31            6
fc00::6a        4      64011    1337    4585        0    0    0 01:06:34            6
fc00::6e        4      64012    1336    4584        0    0    0 01:06:31            6
fc00::72        4      64013    1338    4585        0    0    0 01:06:36            6
fc00::76        4      64014    1337    4585        0    0    0 01:06:34            6
fc00::7a        4      64015    1337    4584        0    0    0 01:06:32            6
fc00::7e        4      64016    1338    4585        0    0    0 01:06:34            6

Total number of neighbors 32

admin@str-msn2700-22:~$ show bgp sum

IPv4 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12931
RIB entries 13027, using 2341 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
10.0.0.1        4      65200    4547    6518        0    0    0 01:07:03         6402
10.0.0.3        4      65200    4546    6518        0    0    0 01:07:02         6402
10.0.0.5        4      65200    4546    6518        0    0    0 01:07:03         6402
10.0.0.7        4      65200    4546    6518        0    0    0 01:07:02         6402
10.0.0.9        4      65200    4546    6518        0    0    0 01:07:02         6402
10.0.0.11       4      65200    4546    6518        0    0    0 01:07:03         6402
10.0.0.13       4      65200    4546    6518        0    0    0 01:07:03         6402
10.0.0.15       4      65200    4546    6518        0    0    0 01:07:01         6402
10.0.0.17       4      65200    4546    6518        0    0    0 01:07:03         6402
10.0.0.19       4      65200    4547    6519        0    0    0 01:07:04         6402
10.0.0.21       4      65200    4546    6518        0    0    0 01:07:02         6402
10.0.0.23       4      65200    4546    6518        0    0    0 01:07:01         6402
10.0.0.25       4      65200    4546    6518        0    0    0 01:07:03         6402
10.0.0.27       4      65200    4545    6517        0    0    0 01:07:00         6402
10.0.0.29       4      65200    4546    6518        0    0    0 01:07:01         6402
10.0.0.31       4      65200    4546    6518        0    0    0 01:07:02         6402
10.0.0.33       4      64001    1346    6937        0    0 2807 00:00:05            7
10.0.0.35       4      64002    1346    6518        0    0    0 01:07:02            6
10.0.0.37       4      64003    1347    6518        0    0    0 01:07:03            7
10.0.0.39       4      64004    1346    6518        0    0    0 01:07:03            6
10.0.0.41       4      64005    1342    4581        0    0    0 01:06:51            6
10.0.0.43       4      64006    1342    4582        0    0    0 01:06:52            6
10.0.0.45       4      64007    1342    4581        0    0    0 01:06:50            6
10.0.0.47       4      64008    1341    4579        0    0    0 01:06:48            6
10.0.0.49       4      64009    1341    4581        0    0    0 01:06:49            6
10.0.0.51       4      64010    1342    4581        0    0    0 01:06:51            6
10.0.0.53       4      64011    1343    4582        0    0    0 01:06:52            6
10.0.0.55       4      64012    1342    4581        0    0    0 01:06:50            6
10.0.0.57       4      64013    1341    4579        0    0    0 01:06:48            6
10.0.0.59       4      64014    1343    4582        0    0    0 01:06:53            6
10.0.0.61       4      64015    1342    4581        0    0    0 01:06:51            6
10.0.0.63       4      64016    1343    4582        0    0    0 01:06:52            6

Total number of neighbors 32

IPv6 Unicast Summary:
BGP router identifier 10.1.0.32, local AS number 65100 vrf-id 0
BGP table version 12927
RIB entries 13025, using 2340 KiB of memory
Peers 32, using 654 KiB of memory
Peer groups 2, using 128 bytes of memory

Neighbor        V         AS MsgRcvd MsgSent   TblVer  InQ OutQ  Up/Down State/PfxRcd
fc00::2         4      65200    4548    5278        0    0    0 01:07:03         6402
fc00::6         4      65200    4547    5278        0    0    0 01:07:02         6402
fc00::a         4      65200    4547    5278        0    0    0 01:07:03         6402
fc00::e         4      65200    4547    5278        0    0    0 01:07:02         6402
fc00::12        4      65200    4547    5278        0    0    0 01:07:02         6402
fc00::16        4      65200    4547    5278        0    0    0 01:07:03         6402
fc00::1a        4      65200    4547    5278        0    0    0 01:07:03         6402
fc00::1e        4      65200    4547    5278        0    0    0 01:07:01         6402
fc00::22        4      65200    4547    5278        0    0    0 01:07:03         6402
fc00::26        4      65200    4548    5279        0    0    0 01:07:04         6402
fc00::2a        4      65200    4547    5278        0    0    0 01:07:02         6402
fc00::2e        4      65200    4547    5278        0    0    0 01:07:01         6402
fc00::32        4      65200    4547    5278        0    0    0 01:07:03         6402
fc00::36        4      65200    4546    5277        0    0    0 01:07:00         6402
fc00::3a        4      65200    4547    5278        0    0    0 01:07:01         6402
fc00::3e        4      65200    4547    5278        0    0    0 01:07:02         6402
fc00::42        4      64001    1346    5529        0    0 2991 00:00:05            6
fc00::46        4      64002    1347    5278        0    0    0 01:07:02            6
fc00::4a        4      64003    1347    5278        0    0    0 01:07:03            6
fc00::4e        4      64004    1347    5278        0    0    0 01:07:03            6
fc00::52        4      64005    1344    4593        0    0    0 01:06:52            6
fc00::56        4      64006    1343    4592        0    0    0 01:06:49            6
fc00::5a        4      64007    1342    4592        0    0    0 01:06:49            6
fc00::5e        4      64008    1344    4593        0    0    0 01:06:53            6
fc00::62        4      64009    1343    4593        0    0    0 01:06:52            6
fc00::66        4      64010    1342    4591        0    0    0 01:06:47            6
fc00::6a        4      64011    1343    4592        0    0    0 01:06:50            6
fc00::6e        4      64012    1342    4591        0    0    0 01:06:47            6
fc00::72        4      64013    1343    4593        0    0    0 01:06:52            6
fc00::76        4      64014    1343    4592        0    0    0 01:06:50            6
fc00::7a        4      64015    1342    4591        0    0    0 01:06:48            6
fc00::7e        4      64016    1343    4592        0    0    0 01:06:50            6

Total number of neighbors 32

@wendani
Remove unused data member
ccbfb48 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
IntfMgr parses dot1q interface
6c99720 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Set dot1q interface state
9a1dde4 
Add function declaration

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Fix compile error
ed9f2e9 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Remove sub interface from STATE_DB in DEL_COMMAND
4ddb2da 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Create sub interface only once; retry if netlink command fails
fb8a564 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Follow naming convention
fb045d3 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Create Port object for sub interface
b15eee6 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Introduce parent_port_id in Port to track the oid of the parent inter…
a02dc31 
…face

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Deal with sub port case in creating router interface
f8e482a 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Let parent port track its child sub ports
f5f49d3 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Remove admin status field and its processing in CONFIG_DB; Runtime mt…
5cf5074 
…u change to sub interface

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Fix compile error
60b3296 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Fix compile error for runtime mtu change
3a6ecce 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Move sub port add/remove as member functions to PortsOrch; Add sub in…
fcd0772 
…terface

rif to flex counter at creation

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Fix compile error
99c887b 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Remove sub interface alias from IntfMgr::m_subIntfList
0014f40 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Merge remote-tracking branch 'public/master' into sub_intf_master
789b198
@wendani
Disable mtu config; Inherit mtu from parent port or port channel
de1577f 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Per sub port interface mtu config
fd66f3d 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
CONFIG_DB table name schema change
4f64469 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Explicitly set admin status in creating sub port interface
b57e78c 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Set admin status up to host sub port interface if admin_status is not…
642c708 
… specified

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@lguohan
Copy link
Contributor

lguohan commented Sep 3, 2019

retest this please

@lguohan
Copy link
Contributor

lguohan commented Sep 3, 2019

please have high level description for this PR? what are changes you have made to help reviewer to understand this PR.

@lguohan
Copy link
Contributor

lguohan commented Oct 30, 2019

retest this please

@wendani
Fix compile error
fd7089e 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Copy link
Contributor Author

wendani commented Oct 31, 2019

retest this please

1 similar comment
@wendani
Copy link
Contributor Author

wendani commented Nov 1, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 2, 2019

retest this please

2 similar comments
@wendani
Copy link
Contributor Author

wendani commented Nov 2, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 2, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 2, 2019

✔️

@wendani
Address comments: Handling all default values for fields at the IntfMgr
7f59f07 
level

Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani wendani requested a review from prsunny November 6, 2019 03:05
qiluo-msft
qiluo-msft approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@qiluo-msft qiluo-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check others' review comments

@wendani
Fix compile error; IntfMgr change variable mtu to type string
c4bd373 
Signed-off-by: Wenda Ni <wenni@microsoft.com>
@wendani
Copy link
Contributor Author

wendani commented Nov 6, 2019

retest this please

1 similar comment
@wendani
Copy link
Contributor Author

wendani commented Nov 7, 2019

retest this please

@wendani
Copy link
Contributor Author

wendani commented Nov 7, 2019

retest this please

@lguohan lguohan merged commit 56d66a1 into sonic-net:master Nov 8, 2019
EdenGri pushed a commit to EdenGri/sonic-swss that referenced this pull request Feb 28, 2022
@xumia
Suppport to verify aboot swi image for secure boot (sonic-net#969)
aae89b7 
* Suppport to verify aboot swi image for secure boot

* Simplify the code

* Fix not return value bug

* Add m2crypto to setup.py

* Change to only verify the image signed by a correct certificate
oleksandrivantsiv pushed a commit to oleksandrivantsiv/sonic-swss that referenced this pull request Mar 1, 2023
@xumia
Fix hung issue when installing linux kernel modules (sonic-net#969)
70e6491
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@qiluo-msft qiluo-msft qiluo-msft approved these changes

@stcheng stcheng Awaiting requested review from stcheng

@lguohan lguohan Awaiting requested review from lguohan

Assignees
No one assigned
Labels
Enhancement ➕
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wendani @lguohan @qiluo-msft @prsunny @stcheng