This repository has been archived by the owner on Aug 31, 2022. It is now read-only.
Support NonTLS option for testing purpose only. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pra-moh
changed the title
hui-ma
reviewed
Feb 3, 2021
hui-ma
approved these changes
Feb 3, 2021
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce new flag "noTLS" on server side to support non TLS option, for testing purpose only.
Why this change?
Need to support nonTLS option on server so that c# client can connect over http.
How did I test it?
Tests done:
Server end:
Gnmi client:
root@f66f87ca51c3:/src/telemetry_standalone/sonic-telemetry/build/bin# ./gnmi_get -xpath_target COUNTERS_DB -xpath COUNTERS/Ethernet0 -target_addr localhost:8080 -notls
== getRequest:
prefix: <
target: "COUNTERS_DB"
path: <
elem: <
name: "COUNTERS"
elem: <
name: "Ethernet0"
encoding: JSON_IETF
== getResponse:
notification: <
timestamp: 1612243637789570057
prefix: <
target: "COUNTERS_DB"
update: <
path: <
elem: <
name: "COUNTERS"
>
elem: <
name: "Ethernet0"
>
>
val: <
json_ietf_val: "{"SAI_PORT_STAT_ETHER_IN_PKTS_128_TO_255_OCTETS":"0","SAI_PORT_STAT_ETHER_RX_OVERSIZE_PKTS":"0","SAI_PORT_STAT_ETHER_STATS_TX_NO_ERRORS":"0","SAI_PORT_STAT_ETHER_TX_OVERSIZE_PKTS":"0","SAI_PORT_STAT_IF_IN_BROADCAST_PKTS":"0","SAI_PORT_STAT_IF_IN_DISCARDS":"0","SAI_PORT_STAT_IF_IN_ERRORS":"0","SAI_PORT_STAT_IF_IN_MULTICAST_PKTS":"0","SAI_PORT_STAT_IF_IN_NON_UCAST_PKTS":"0","SAI_PORT_STAT_IF_IN_OCTETS":"0","SAI_PORT_STAT_IF_IN_UCAST_PKTS":"0","SAI_PORT_STAT_IF_IN_UNKNOWN_PROTOS":"0","SAI_PORT_STAT_IF_OUT_BROADCAST_PKTS":"0","SAI_PORT_STAT_IF_OUT_DISCARDS":"0","SAI_PORT_STAT_IF_OUT_ERRORS":"0","SAI_PORT_STAT_IF_OUT_MULTICAST_PKTS":"0","SAI_PORT_STAT_IF_OUT_NON_UCAST_PKTS":"0","SAI_PORT_STAT_IF_OUT_OCTETS":"0","SAI_PORT_STAT_IF_OUT_QLEN":"0","SAI_PORT_STAT_IF_OUT_UCAST_PKTS":"0","SAI_PORT_STAT_IP_IN_UCAST_PKTS":"0","SAI_PORT_STAT_PFC_0_RX_PKTS":"0","SAI_PORT_STAT_PFC_0_TX_PKTS":"0","SAI_PORT_STAT_PFC_1_RX_PKTS":"0","SAI_PORT_STAT_PFC_1_TX_PKTS":"0","SAI_PORT_STAT_PFC_2_RX_PKTS":"0","SAI_PORT_STAT_PFC_2_TX_PKTS":"0","SAI_PORT_STAT_PFC_3_RX_PKTS":"0","SAI_PORT_STAT_PFC_3_TX_PKTS":"0","SAI_PORT_STAT_PFC_4_RX_PKTS":"0","SAI_PORT_STAT_PFC_4_TX_PKTS":"0","SAI_PORT_STAT_PFC_5_RX_PKTS":"0","SAI_PORT_STAT_PFC_5_TX_PKTS":"0","SAI_PORT_STAT_PFC_6_RX_PKTS":"0","SAI_PORT_STAT_PFC_6_TX_PKTS":"0","SAI_PORT_STAT_PFC_7_RX_PKTS":"0","SAI_PORT_STAT_PFC_7_TX_PKTS":"0"}"
>