[show]: split show interfaces commands into separate file #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guohan Lu <lguohan@gmail.com>
lguohan
commented
Aug 11, 2020
| @@ -95,166 +96,6 @@ def run_command(command, display_cmd=False, return_cmd=False): | |||
| # Global class instance for SONiC interface name to alias conversion | |||
| iface_alias_converter = clicommon.InterfaceAliasConverter() | |||
|
|
|||
| def print_output_in_alias_mode(output, index): | |||
lguohan
commented
Aug 11, 2020
| click.echo(output.rstrip('\n')) | ||
|
|
||
|
|
||
| def run_command_in_alias_mode(command): |
|
This pull request introduces 4 alerts when merging abd44b1 into 7ae8024 - view on LGTM.com new alerts:
|
jleveque
reviewed
Aug 11, 2020
Signed-off-by: Guohan Lu <lguohan@gmail.com>
jleveque
approved these changes
Aug 11, 2020
|
retest this please |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Guohan Lu lguohan@gmail.com
- What I did
[show]: split show interfaces commands into separate file
add extensive test coverage for show interfaces commands.
- How I did it
- How to verify it
unit test and on box test
unit test coverage
a few things not covered.
show breakout (need to check with @zxu why it is not covered before)
show interfaces lpmode (i think this should be add by part of platform efforts)
show interfaces counters ... (this has never been added, need new efforts to add this)
all others commands are almost 100% covered by the unit tests.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)