Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[consutil] Display remote device name in show command #1120

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

Blueve
Copy link
Contributor

@Blueve Blueve commented Sep 17, 2020

- What I did

Display remote device name in consutil show result table

- How I did it

Read remote device name from CONFIG_DB and append it to consutil show result table.

- will be displayed if there are no configured remote device name.

- How to verify it

Build a deb and test it on a physical DUT with following CONSOLE_PORT configuration:

    "CONSOLE_PORT": {
        "1": {
            "remote_device": "switch1",
            "baud_rate": "9600",
            "flow_control": "1"
        }
    }

- Previous command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo consutil show
  Line    Actual/Configured Baud    PID    Start Time
------  ------------------------  -----  ------------
     0      9600/-              
     1      9600/9600           
     2      9600/-              
     3      9600/-              
     4      9600/-              
     5      9600/-              
     6      9600/-              
     7      9600/-              
     8      9600/-              
     9      9600/-              
    10      9600/-              
    11      9600/-              
    12      9600/-              
    13      9600/-              
    14      9600/-              
    15      9600/-              
    16      9600/-              
    17      9600/-              
    18      9600/-              
    19      9600/-              
    20      9600/-              
    21      9600/-              
    22      9600/-              
    23      9600/-              
    24      9600/-              
    25      9600/-              
    26      9600/-              
    27      9600/-              
    28      9600/-              
    29      9600/-              
    30      9600/-              
    31      9600/-              
    32      9600/-              
    33      9600/-              
    34      9600/-              
    35      9600/-              
    36      9600/-              
    37      9600/-              
    38      9600/-              
    39      9600/-              
    40      9600/-              
    41      9600/-              
    42      9600/-              
    43      9600/-              
    44      9600/-              
    45      9600/-              
    46      9600/-              
    47      9600/-              

- New command output (if the output of a command-line utility has changed)

admin@sonic:~$ sudo consutil show
  Line    Actual/Configured Baud    PID    Start Time    Device
------  ------------------------  -----  ------------  --------
     0      9600/-                                            -
     1      9600/9600                                   switch1
     2      9600/-                                            -
     3      9600/-                                            -
     4      9600/-                                            -
     5      9600/-                                            -
     6      9600/-                                            -
     7      9600/-                                            -
     8      9600/-                                            -
     9      9600/-                                            -
    10      9600/-                                            -
    11      9600/-                                            -
    12      9600/-                                            -
    13      9600/-                                            -
    14      9600/-                                            -
    15      9600/-                                            -
    16      9600/-                                            -
    17      9600/-                                            -
    18      9600/-                                            -
    19      9600/-                                            -
    20      9600/-                                            -
    21      9600/-                                            -
    22      9600/-                                            -
    23      9600/-                                            -
    24      9600/-                                            -
    25      9600/-                                            -
    26      9600/-                                            -
    27      9600/-                                            -
    28      9600/-                                            -
    29      9600/-                                            -
    30      9600/-                                            -
    31      9600/-                                            -
    32      9600/-                                            -
    33      9600/-                                            -
    34      9600/-                                            -
    35      9600/-                                            -
    36      9600/-                                            -
    37      9600/-                                            -
    38      9600/-                                            -
    39      9600/-                                            -
    40      9600/-                                            -
    41      9600/-                                            -
    42      9600/-                                            -
    43      9600/-                                            -
    44      9600/-                                            -
    45      9600/-                                            -
    46      9600/-                                            -
    47      9600/-                                            -

@Blueve Blueve merged commit c138eaa into sonic-net:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants