Add show reboot-history
#1154
Closed
Add show reboot-history
#1154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jleveque
suggested changes
Oct 9, 2020
There was a problem hiding this comment.
I feel like this command should be in the same group as show reboot-cause.
Either:
show reboot-cause
show reboot-cause history
or
show reboot cause
show reboot history
However, if we go with the latter, we would also need to add an alias from show reboot-cause to show reboot cause to retain backward-compatibility.
sonic-net#1151) To ensure a smooth transition once we stop installing the dependencies explicitly in the SONiC image. We can upgrade dependencies selectively in the future. Also had to replace single-quotes with double-quotes in expected Click error messages, as it seems the Click package installed via pip uses double quotes, whereas the package installed via Debian used single-quotes.
|
@sujinmkang , please add unit test. |
…onic-net#1161) Add instructions for setting up an environment to build the sonic-utilities package and run unit tests Resolves sonic-net#1160
* Add 'show' CLI for system-health feature Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com> * Add unit test for 'system-health' feature, add support for testing in 'show' script, Fix comments Signed-off-by: Shlomi Bitton <shlomibi@mellanox.com> * Fix additional comments * Fix comments * Update Command-Reference.md Add a CLI reference for system-health feature. * Fix LGTM alerts * Fix comment Change 'Ignore' to 'Ignored' * Update Command-Reference.md Fix example output * Update Command-Reference.md * Change 'summary' output and adapt test and reference to the new change * Update main.py * Fix multiline output for expected output * keep output aligned * Fix import for unit testing after community change * Add clicommon for @cli.group after community change * Align changes in the feature to the CLI on commit sonic-net/sonic-buildimage@8ea2ab5 Signed-off-by: Shlomi Bitton <shlomibi@nvidia.com> * Update main.py * Move new group CLI into a separate file * Organize imports per PEP8 standards * Organize imports per PEP8 standards * Reformat docstring for readability
…onic-net#1162) Previous code only enumerate on distinct neighbors, thus only one port is shown for a neighbor. Signed-off-by: Guohan Lu <lguohan@gmail.com>
…1155) * Update lib.py * Keep the code format align see add spaces for special symbols * remove unused code
|
This pull request introduces 1 alert when merging d8977fe into 3a7457c - view on LGTM.com new alerts:
|
The 'ipaddress.ip_interface' accepts only unicode str as input, which is default in python3. However, an exception will raise when running in python2. This commit fix the issue. Signed-off-by: bingwang <bingwang@microsoft.com>
…-net#1157) * Add watermark testcases and mock counters Signed-off-by: Neetha John <nejo@microsoft.com>
…xists (sonic-net#1173) Signed-off-by: Jing Kan jika@microsoft.com
sonic-net#1166) Signed-off-by: Jing Kan jika@microsoft.com
jleveque
suggested changes
Oct 15, 2020
jleveque
reviewed
Oct 15, 2020
jleveque
suggested changes
Oct 15, 2020
|
Please review the new PR : #1210. Closing this PR since my rebase attempt messed up the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
To make the reboot cause history information available for telemetry service, during processing the reboot-cause on boot, the information is saved in state-db.
The cli command
show reboot-causeis changed to support the new file format and file name.New command
show reboot-cause historyis added to display the reboot-cause information which is stored in state-db.- How I did it
Add the 'show reboot-cause history' command to read up to the10 previous reboot-cause information from state-db and display them.
Read the last reboot-cause from the new file "previous-reboot-cause.json" and process the data to display for
show reboot-cause- How to verify it
Unit test added.
Verified also in DUT
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
HLD : sonic-net/SONiC#669