Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix watermark stat display title as "Buffer Pool" instead of "Shared Pool" #1322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rck-innovium
Copy link
Contributor

"show buffer_pool watermark" reads SAI_BUFFER_POOL_STAT_WATERMARK_BYTES. This corresponds to the total buffer occupancy and not the shared buffer pool occupancy.

fixes #1321

- What I did
Fixed the display string in the watermarkstat script.

- How to verify it
show buffer_pool watermark

- Previous command output (if the output of a command-line utility has changed)

$ show buffer_pool watermark
Shared pool maximum occupancy:
                 Pool    Bytes
---------------------  -------
ingress_lossless_pool        0
           lossy_pool     4032

- New command output (if the output of a command-line utility has changed)

$ show buffer_pool watermark
Buffer pool maximum occupancy:
                 Pool    Bytes
---------------------  -------
ingress_lossless_pool        0
           lossy_pool     1568

@ghost
Copy link

ghost commented Dec 20, 2020

CLA assistant check
All CLA requirements met.

@rck-innovium
Copy link
Contributor Author

retest please

@rck-innovium
Copy link
Contributor Author

Retest this please.

1 similar comment
@rck-innovium
Copy link
Contributor Author

Retest this please.

@lguohan
Copy link
Contributor

lguohan commented Apr 14, 2021

can you resolve the conflict?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"show buffer_pool watermark" output heading is incorrect
3 participants