-
Notifications
You must be signed in to change notification settings - Fork 667
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic-package-manager] first phase implementation of sonic-package-manager #1527
Conversation
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
…packages-migration
Signed-off-by: Stepan Blyshchak <stepanb@nvidia.com>
…packages-migration Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This pull request introduces 2 alerts when merging f2ee39f into 1ee04fb - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This pull request introduces 2 alerts when merging c724569 into 1ee04fb - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This pull request introduces 2 alerts when merging 3dc793f into 1ee04fb - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
This pull request introduces 2 alerts when merging faeadcf into 1ee04fb - view on LGTM.com new alerts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest of the review can be done during sub group meeting, with Stephan leading it.
Co-authored-by: Joe LeVeque <jleveque@users.noreply.github.com>
This pull request introduces 2 alerts when merging ae1ce45 into 28b64ec - view on LGTM.com new alerts:
|
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Co-authored-by: Jan Klare <janklare@gmail.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
How are the docker image tags going to be used here? Maybe they should be shown instead or additionally to the "Version" ? |
@renukamanavalan do we still have open issues following all the above fixes? |
Signed-off-by: Stepan Blyschak <stepanb@nvidia.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This is a large PR but the code is very clean, well-organized and easy to read. Thank you!
Ready for merge. Waiting for build to complete. |
…anager (sonic-net#1527) What I did Implemented sonic-package-manager utility to manager SONiC Packages as per HLD sonic-net/SONiC#682. Implemented optional logic to migrate packages into new SONiC image in sonic-installer. How I did it Implemented as per HLD sonic-net/SONiC#682. How to verify it (Doc: sonic-net/SONiC#682) install package uninstall package upgrade package S2S upgrade THANK YOU, Stepan!
What I did
Implemented sonic-package-manager utility to manager SONiC Packages as per HLD sonic-net/SONiC#682.
Implemented optional logic to migrate packages into new SONiC image in sonic-installer.
How I did it
Implemented as per HLD sonic-net/SONiC#682.
How to verify it
(Doc: sonic-net/SONiC#682)
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)