[show][config] cli support for firmware upgrade on Y-Cable #1528

vdahiya12 · 2021-03-26T14:18:27Z

Summary:
This PR provides the support for adding CLI commands for activatie, download, upgrade firmware on the Y-cable
In particular these Cli commands are supported:
sudo config muxcable firmware download Ethernet0
sudo config muxcable firmware rollback Ethernet0
sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0

Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com

What I did

Added the support for firmware upgrade CLI on Y cable

How I did it

added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py

admin@STR43-0101-0101-01LT0:/usr$ sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0
firmware download successful Ethernet0

admin@STR43-0101-0101-01LT0:~/credo_script_01_21$ sudo config muxcable firmware activate Ethernet0
firmware activate successful Ethernet0

admin@STR43-0101-0101-01LT0:~/credo_script_01_21$ sudo config muxcable firmware rollback Ethernet0
firmware rollback successful Ethernet0

How to verify it

Ran the command on a 7050cx3 arista switch

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-26T14:27:19Z

This pull request introduces 1 alert when merging 233f238 into 1f1696a - view on LGTM.com

new alerts:

1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-26T15:01:15Z

This pull request introduces 3 alerts when merging b44a442 into 1f1696a - view on LGTM.com

new alerts:

3 for Unused local variable

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

jleveque

There is a lot of duplicate code in these new functions. Can you look into writing a helper function(s) so as to share common code?

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-29T17:55:57Z

This pull request introduces 1 alert when merging 63c6977 into 6b51bcd - view on LGTM.com

new alerts:

1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-29T18:12:47Z

This pull request introduces 1 alert when merging d04d25a into 6b51bcd - view on LGTM.com

new alerts:

1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-29T18:28:21Z

This pull request introduces 1 alert when merging a81c943 into 6b51bcd - view on LGTM.com

new alerts:

1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-29T19:10:12Z

This pull request introduces 1 alert when merging e12a491 into 6b51bcd - view on LGTM.com

new alerts:

1 for Unused local variable

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

jleveque · 2021-03-30T17:15:00Z

config/muxcable.py

+        if rc:
+            sys.exit(CONFIG_SUCCESSFUL)
+        else:
+            sys.exit(CONFIG_FAIL)


rc seems redundant as a bool. Suggest setting rc = CONFIG_SUCCESSFUL on line 750, rc = CONFIG_FAIL on line 764, and here simply call sys.exit(rc).

Suggest making this change throughout the file.

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-03-30T19:47:31Z

This pull request introduces 1 alert when merging 52ece4b into 6b51bcd - view on LGTM.com

new alerts:

1 for Syntax error

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 · 2021-03-30T20:02:17Z

show/muxcable.py

@@ -820,3 +820,196 @@ def switchmode(port):
        click.echo(tabulate(body, headers=headers))
        if rc == False:
            sys.exit(EXIT_FAIL)
+
+
+def create_result_dict(physical_port, mux_info_dict, result_dict):


@jleveque should we move all this to y_cable.py or let it remain here ?
this is in regards to the newer resultant dict you suggested.
For example ?
{
"version_nic_active": "0.6MS",
"version_nic_inactive": "0.5MS",
"version_nic_next": "0.6MS",
"version_self_active": "0.5MS",
"version_self_inactive": "0.6MS",
"version_self_next": "0.6MS",
"version_peer_active": "0.6MS",
"version_peer_inactive": "0.6MS",
"version_peer_next": "0.6MS",
}

In y_cable.py the function to get firmware from a end should return active, inactive and next values. I would think here we would call it for each end to gather the firmware versions for all ends that we can.

refactored, new API's used here

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

lgtm-com · 2021-04-04T23:01:55Z

This pull request introduces 1 alert when merging f1c1550 into 9bbc25f - view on LGTM.com

new alerts:

1 for Unused local variable

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

config/muxcable.py

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

yxieca · 2021-04-08T18:17:35Z

@vdahiya12 this change cannot be cherry-picked to 202012 branch cleanly. Can you find the dependent PR or create separate PR with this change for 202012 branch?

…#1528) Summary: This PR provides the support for adding CLI commands for activatie, download, upgrade firmware on the Y-cable In particular these Cli commands are supported: sudo config muxcable firmware download Ethernet0 sudo config muxcable firmware rollback Ethernet0 sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0 Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com What I did Added the support for firmware upgrade CLI on Y cable How I did it added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 · 2021-04-12T16:49:32Z

opened a PR for 202012 branch
#1558

…1558) * [show][config] cli support for firmware upgrade on Y-Cable (#1528) Summary: This PR provides the support for adding CLI commands for activatie, download, upgrade firmware on the Y-cable In particular these Cli commands are supported: sudo config muxcable firmware download Ethernet0 sudo config muxcable firmware rollback Ethernet0 sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0 Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com What I did Added the support for firmware upgrade CLI on Y cable How I did it added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

…#1528) Summary: This PR provides the support for adding CLI commands for activatie, download, upgrade firmware on the Y-cable In particular these Cli commands are supported: sudo config muxcable firmware download Ethernet0 sudo config muxcable firmware rollback Ethernet0 sudo config muxcable firmware download ~/AEC_WYOMING_B52Yb0_MS_0.6_20201218.bin Ethernet0 Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com What I did Added the support for firmware upgrade CLI on Y cable How I did it added the changes in sonic-utilities/show and sonic-utilities/config by changing the muxcable.py Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

Support ACL Table type Mirrorv6 for Innovium (sonic-net#1528) Enable v6 ACL rule based Mirroring for Innovium Platform Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>

[config] cli support for firmware upgrade on Y-Cable

233f238

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 marked this pull request as draft March 26, 2021 14:18

fix LGTM

b44a442

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix LGTM

0b3bdba

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 requested a review from jleveque March 26, 2021 16:53

vdahiya12 added config Request for 202012 Branch labels Mar 26, 2021

vdahiya12 marked this pull request as ready for review March 26, 2021 16:54

jleveque suggested changes Mar 26, 2021

View reviewed changes

refactor

63c6977

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix LGTM

d04d25a

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix python warnings

a81c943

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix some syntax

e12a491

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

add logic for show

19debd8

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 changed the title ~~[config] cli support for firmware upgrade on Y-Cable~~ [show][config] cli support for firmware upgrade on Y-Cable Mar 30, 2021

vdahiya12 added the show label Mar 30, 2021

jleveque suggested changes Mar 30, 2021

View reviewed changes

fix comment/ add more logic

52ece4b

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix LGTM

77b1874

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

vdahiya12 commented Mar 30, 2021

View reviewed changes

add unit

f1c1550

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

fix LGTM

70004f4

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

jleveque reviewed Apr 5, 2021

View reviewed changes

config/muxcable.py Outdated Show resolved Hide resolved

remove debug statements

1af160c

Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>

jleveque approved these changes Apr 5, 2021

View reviewed changes

vdahiya12 merged commit 0ce6a25 into sonic-net:master Apr 5, 2021

yozhao101 mentioned this pull request Apr 5, 2021

[sonic-utilities] Update submodule. sonic-net/sonic-buildimage#7227

Merged

yxieca removed the Request for 202012 Branch label Apr 8, 2021

yozhao101 mentioned this pull request Aug 22, 2021

[sonic-utilities] Update the submodule of sonic-utilities. sonic-net/sonic-buildimage#8551

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[show][config] cli support for firmware upgrade on Y-Cable #1528

[show][config] cli support for firmware upgrade on Y-Cable #1528

vdahiya12 commented Mar 26, 2021 •

edited

Loading

lgtm-com bot commented Mar 26, 2021

lgtm-com bot commented Mar 26, 2021

jleveque left a comment

lgtm-com bot commented Mar 29, 2021

lgtm-com bot commented Mar 29, 2021

lgtm-com bot commented Mar 29, 2021

lgtm-com bot commented Mar 29, 2021

jleveque Mar 30, 2021

vdahiya12 Apr 5, 2021

lgtm-com bot commented Mar 30, 2021

vdahiya12 Mar 30, 2021

jleveque Mar 30, 2021 •

edited

Loading

vdahiya12 Apr 5, 2021

lgtm-com bot commented Apr 4, 2021

yxieca commented Apr 8, 2021

vdahiya12 commented Apr 12, 2021

[show][config] cli support for firmware upgrade on Y-Cable #1528

[show][config] cli support for firmware upgrade on Y-Cable #1528

Conversation

vdahiya12 commented Mar 26, 2021 • edited Loading

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

lgtm-com bot commented Mar 26, 2021

lgtm-com bot commented Mar 26, 2021

jleveque left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Mar 29, 2021

lgtm-com bot commented Mar 29, 2021

lgtm-com bot commented Mar 29, 2021

lgtm-com bot commented Mar 29, 2021

jleveque Mar 30, 2021

Choose a reason for hiding this comment

vdahiya12 Apr 5, 2021

Choose a reason for hiding this comment

lgtm-com bot commented Mar 30, 2021

vdahiya12 Mar 30, 2021

Choose a reason for hiding this comment

jleveque Mar 30, 2021 • edited Loading

Choose a reason for hiding this comment

vdahiya12 Apr 5, 2021

Choose a reason for hiding this comment

lgtm-com bot commented Apr 4, 2021

yxieca commented Apr 8, 2021

vdahiya12 commented Apr 12, 2021

vdahiya12 commented Mar 26, 2021 •

edited

Loading

jleveque Mar 30, 2021 •

edited

Loading