-
Notifications
You must be signed in to change notification settings - Fork 659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TPID CONFIG] Added TPID configuration CLI support #1618
Conversation
Signed-off-by: Gen-Hwa Chiang <gechiang@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Formatting and alignment of code blocks in rendered Command-Reference.md appear incorrect. Formatting could be due to spaces preceding triple backticks. Please fix.
…s tpid output incorrectly
Thanks for catching it! |
Looks good from my perspective. Please wait for other reviewers.
* [TPID CONFIG] Added TPID configuration CLI support Signed-off-by: Gen-Hwa Chiang <gechiang@microsoft.com> * Added command-reference update for the new config TPID and show TPID related commands * Fixed Reference-command spacing issue that caused the show interfaces tpid output incorrectly
* [TPID CONFIG] Added TPID configuration CLI support Signed-off-by: Gen-Hwa Chiang <gechiang@microsoft.com> * Added command-reference update for the new config TPID and show TPID related commands * Fixed Reference-command spacing issue that caused the show interfaces tpid output incorrectly
Signed-off-by: Gen-Hwa Chiang gechiang@microsoft.com
What I did
This PR is part of the TPID CONFIG SONiC feature set to support port/LAG TPID configuration.
TPID HLD PR: (sonic-net/SONiC#681)
There are total of 3 PRs across different submodules to achieve this feature support.
Please refer to the TPID HLD listed above for more details on the TPID configuration feature support.
Here is a quick summary for this PR changes:
Here is some sample output of the TPID configuration attempts:
How to verify it
Besides validating this on a HW SKU that is capable of handling TPID attribute setting, new unit testcase was also added to ensure most of the TPID feature code is covered:
New command output (if the output of a command-line utility has changed)
As part of this feature, a new show command "show interface tpid" is also added.
Here is some sample output:
Corresponding command reference doc is also updated to include the new changes for config TPID and show TPID related commands.