lldp-show: skip containers not in running state #1656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With sonic-net/sonic-buildimage#7477 asic-dependent containers are created/started only when the ASIC is detected by the platform. The
lldp show
command throws exception/errors if some containers are not present.What I did
Add an additional check for container to be in
running
state before processing additional container state information.How I did it
Introduced a is_instance_running() routine which will use docker-inspect to check for the state of the container.
How to verify it
Verified using
lldp show table
commandPrevious command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)