Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[debug dump util] Match Infrastructure #1666

Merged
merged 20 commits into from
Jul 14, 2021
Merged

[debug dump util] Match Infrastructure #1666

merged 20 commits into from
Jul 14, 2021

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Jun 11, 2021 •
edited
Loading

DEBUG DUMP UTIL PR SEQ: 1

What I did

HLD for Dump Utility: HLD.

  • Added the Logic for Match Infrastructure along with corresponding unit tests.

Note: Before merging other PR's, please merge this first

For More Info on MatchRequest and MatchEngine, Check this section in the HLD:
MatchInfra

How I did it

How to verify it

tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_bad_key_pattern PASSED [ 82%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_bad_request PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_invalid_combination PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_invalid_db PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_just_keys_return_fields_compat PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_file PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_source PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_table PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_no_value PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_return_fields_bad_format PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_vague_source PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchRequestValidation::test_valid_match_request PASSED [ 83%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_match_list_type PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_field_value_no_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source_with_key_ptrn PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_file_source_with_not_only_return_keys PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_for_no_key_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_for_no_match PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_just_keys_false PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_key_pattern_complex PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_key_pattern_wildcard PASSED [ 84%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_match_entire_list PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_all_filtering PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_field_value_filtering PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_fields_with_key_filtering PASSED [ 85%]
tests/dump_tests/match_engine_test.py::TestMatchEngine::test_return_keys PASSED [ 85%]

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@vivekrnv
Match Infra Added
5bec449 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Missing file added
4da400b 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Multi-Asic Changes Made
6c8667a 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Minor Changes
42118c0 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Minor Fixes
f83317a 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Merge branch 'master' of https://github.com/vivekreddynv/sonic-utilities
724d584 
 into match_engine
@vivekrnv
Name Change and match_list changes made
c9dcfef 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Minor Typo
bd47df0 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Final Changes before review made
b8da286 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Comments addressed
8cd32cd 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Comments addressed
6da04b4 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
pylint issues dealt with
1a08fe8 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Minor Fixes
3859648 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Moved the mock files dir
2c73a59 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
This was referenced Jun 11, 2021
Merged
Merged
SuvarnaMeenakshi
SuvarnaMeenakshi requested changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please added unit test for namespace DBs as well.

dump/match_infra.py Outdated Show resolved Hide resolved
dump/match_infra.py Show resolved Hide resolved
dump/match_infra.py Outdated Show resolved Hide resolved
dump/match_infra.py Show resolved Hide resolved
dump/match_infra.py Outdated Show resolved Hide resolved
tests/dump_tests/match_engine_test.py Show resolved Hide resolved
@vivekrnv
Copy link
Contributor Author

vivekrnv commented Jun 22, 2021 •
edited
Loading

Please added unit test for namespace DBs as well.

Added the Test

@vivekrnv
Namespace changes updated
30528b4 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Multi-Asic Changes Made
7eded22 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Minor Changes
0a4765d 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@vivekrnv
Merge branch 'master' of https://github.com/Azure/sonic-utilities int…
0b07a99 
…o match_engine
@vivekrnv
moved from utilities common to sonic_py_common
0cdc865 
Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>
@liat-grozovik
Copy link
Collaborator

@SuvarnaMeenakshi could you please review following unit test added?

SuvarnaMeenakshi
SuvarnaMeenakshi approved these changes Jul 7, 2021
View reviewed changes
Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuvarnaMeenakshi SuvarnaMeenakshi merged commit 9ae6f6b into sonic-net:master Jul 14, 2021
@vivekrnv
Copy link
Contributor Author

Request for 202106

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-utilities that referenced this pull request Aug 10, 2021
@vivekrnv @raphaelt-nvidia
[debug dump util] Match Infrastructure (sonic-net#1666)
feb89f6 
What I did
HLD for Dump Utility: HLD.

Added the Logic for Match Infrastructure along with corresponding unit tests.
Note: Before merging other PR's, please merge this first

For More Info on MatchRequest and MatchEngine, Check this section in the HLD:
MatchInfra
judyjoseph pushed a commit that referenced this pull request Aug 26, 2021
@vivekrnv @judyjoseph
[debug dump util] Match Infrastructure (#1666)
9427cd6 
What I did
HLD for Dump Utility: HLD.

Added the Logic for Match Infrastructure along with corresponding unit tests.
Note: Before merging other PR's, please merge this first

For More Info on MatchRequest and MatchEngine, Check this section in the HLD:
MatchInfra
@raphaelt-nvidia raphaelt-nvidia mentioned this pull request Oct 13, 2021
Merged
SuvarnaMeenakshi pushed a commit that referenced this pull request Nov 10, 2021
@raphaelt-nvidia
[debug dump util] Vlan Module Added (#1877)
5e95fc3 
What I did
Implemented vlan and vlan_member modules for debug dump utility.

How I did it
Used infrastructure and followed examples in
#1666
#1667
#1668
#1669
#1670

How to verify it
On switch: dump state vlan <vlan_name>
dump state vlan_member '<vlan_name|<member_name>'
Unit test: pytest-3 dump_tests/module_tests/vlan_test.py (same test file covers both vlan and vlan_member)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liat-grozovik liat-grozovik liat-grozovik approved these changes

@SuvarnaMeenakshi SuvarnaMeenakshi SuvarnaMeenakshi approved these changes

Assignees
No one assigned
Labels
Included in 202106 Branch Request for 202106 Branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivekrnv @liat-grozovik @SuvarnaMeenakshi @judyjoseph