[intfutil]Let speed 100M/2.5G can be correct displayed. #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parse the speed string:
The speed string length < len('1000'), display speed by unit 'M'
else display speed by unit 'G'
|
retest |
Blueve
requested changes
Jul 29, 2022
| @@ -138,12 +138,28 @@ def appl_db_port_status_get(appl_db, intf_name, status_type): | |||
| if status is None: | |||
| return "N/A" | |||
| if status_type == PORT_SPEED and status != "N/A": | |||
| status = '{}G'.format(status[:-3]) | |||
| if (len(status) < len('1000')): | |||
There was a problem hiding this comment.
I think it would be great if you can extract these lines to a new methods and reuse it
And it might be better to convert to numbers than manipulate text
|
This issue has been addressed in another PR: #2110 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parse the speed string:
The speed string length < len('1000'), display speed by unit 'M'
else display speed by unit 'G'
What I did
Let speed 100M/2.5G can be correct displayed
How I did it
Parse the speed string:
The speed string length < len('1000'), display speed by unit 'M'
else display speed by 'G'
How to verify it
Real device verification.
Verify by the CLI cmd 'show interfaces status' output on the port which is configure with speed 100M
100M shall be shown in the Speed field
Verify by the CLI cmd 'show interfaces status' output on the port which is configured with speed 2.5G
2.5G shall be shown in the Speed field.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)