Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[acl-loader] Add no_default_deny_rule option to acl-loader #2032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bingwang-ms
Copy link
Contributor

@bingwang-ms bingwang-ms commented Jan 24, 2022

Signed-off-by: bingwang bingwang@microsoft.com

This PR is to add a new option no_default_deny_rule to acl-loader.
The script will not create default deny rules when loading acl file when no_default_deny_rule is set.
This optional is optional, and the default value is False. So the default behavior is not changed.

What I did

Fix #2026
Add a new option no_default_deny_rule to acl-loader.

How I did it

Add an optional option.

How to verify it

  1. Vefified by UT
  2. Verified by running the new script on a testbed.

Previous command output (if the output of a command-line utility has changed)

Usage: acl-loader update full [OPTIONS] FILENAME

  Full update of ACL rules configuration. If a table_name is provided, the
  operation will be restricted in the specified table. 

Options:
  --table_name TEXT
  --session_name TEXT
  --mirror_stage [ingress|egress]
  --max_priority INTEGER
  --help                          Show this message and exit.

New command output (if the output of a command-line utility has changed)

Usage: acl-loader update full [OPTIONS] FILENAME

  Full update of ACL rules configuration. If a table_name is provided, the
  operation will be restricted in the specified table. The default deny
  rules will be applied to ingress ACL table unless no_default_deny_rule is
  set.

Options:
  --table_name TEXT
  --session_name TEXT
  --mirror_stage [ingress|egress]
  --max_priority INTEGER
  --no_default_deny_rule
  --help                          Show this message and exit.

Signed-off-by: bingwang <bingwang@microsoft.com>
@bingwang-ms
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ACL] Add no_default_deny_rule to acl-loader script
1 participant