[config][mclag] Fix import statement in mclag.py #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft @xumia Please review |
qiluo-msft
approved these changes
Feb 17, 2022
arlakshm
approved these changes
Feb 17, 2022
qiluo-msft
changed the title
|
We recently fixed the build on master branch. Could you rebase to master or merge master? |
added 2 commits
February 18, 2022 00:52
…o fix_mclag_import
…o fix_mclag_import
|
@qiluo-msft CI passed, please help to merge. |
|
@qiluo-msft @arlakshm Could we merge this? |
6 tasks
bratashX
pushed a commit
to bratashX/sonic-utilities
that referenced
this pull request
May 13, 2022
#### What I did
Fixed import error
Added unit test for that case
#### How I did it
Used relative import to import file from the current package.
#### How to verify it
Try to configure mclag with Port as peer interface
```
sudo config mclag add 1 192.168.3.1 192.168.3.2 Ethernet12
```
#### Previous command output (if the output of a command-line utility has changed)
```
admin@sonic:~$ sudo config mclag add 1 192.168.3.1 192.168.3.2 Ethernet12
Traceback (most recent call last):
File "/usr/local/bin/config", line 8, in <module>
sys.exit(config())
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 764, in __call__
return self.main(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 717, in main
rv = self.invoke(ctx)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 1137, in invoke
return _process_result(sub_ctx.command.invoke(sub_ctx))
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 956, in invoke
return ctx.invoke(self.callback, **ctx.params)
File "/usr/local/lib/python3.9/dist-packages/click/core.py", line 555, in invoke
return callback(*args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/click/decorators.py", line 17, in new_func
return f(get_current_context(), *args, **kwargs)
File "/usr/local/lib/python3.9/dist-packages/config/mclag.py", line 140, in add_mclag_domain
if (peer_ifname.startswith("Ethernet") is True) and (check_if_interface_is_valid(db, peer_ifname) is False):
File "/usr/local/lib/python3.9/dist-packages/config/mclag.py", line 89, in check_if_interface_is_valid
from main import interface_name_is_valid
ModuleNotFoundError: No module named 'main'
```
#### New command output (if the output of a command-line utility has changed)
```
admin@sonic:~$ sudo config mclag add 1 192.168.3.1 192.168.3.2 Ethernet12
admin@sonic:~$
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed import error
Added unit test for that case
How I did it
Used relative import to import file from the current package.
How to verify it
Try to configure mclag with Port as peer interface
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)