Support for platforms based on Clounix Networks' device #2108
Conversation
|
@kcudnik can you kindly approving review for this pull request ? |
| @@ -713,6 +713,11 @@ then | |||
| systemctl stop "$service_name" | |||
| fi | |||
|
|
|||
| if [[ "$sonic_asic_type" = 'clounix' ]]; | |||
| then | |||
| systemctl stop clx-modules.service || debug "Ignore stopping clounix service error $?" | |||
There was a problem hiding this comment.
should failure be logged as error in syslog instead of debug?
There was a problem hiding this comment.
Hi kcudnik:
You're right, "debug" will be recorded in syslog,because in this fast-boot file the definition of "debug" is：
function debug()
{
if [[ x"${VERBOSE}" == x"yes" ]]; then
echo date $@
fi
logger "$@"
}
There was a problem hiding this comment.
@kcudnik
Hi Kamil,
Thanks for your comment.
As Qinghua’s mentioned, this log will be logged in syslog, looks like this script is using the similar style.
May I know if we can keep this this change?
Thanks again for your feedback.
|
@qiluo-msft |
|
@qiluo-msft can you kindly approving review for this pull request ? |
|
@vaibhavhd Could you please kindly approving review for this PR? |
|
@kcudnik Could you please kindly approving review and merging for this PR? |
|
LGTM. Sorry for getting late to this. Please sync with the latest and solve merge conflicts. |
|
EasyCLA have done |
What I did
Add support for platforms based on Clounix Networks' device
How I did it
Add support for platforms based on Clounix Networks' device
How to verify it
Verified on pythical DUT
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)