Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance "config interface type/advertised-type" to be blocked on RJ45 ports #2112

Merged
merged 4 commits into from
Apr 19, 2022

Conversation

keboliu
Copy link
Collaborator

@keboliu keboliu commented Mar 22, 2022

What I did

Block "config interface type" and "config interface advertised type" configuration on RJ45 ports

admin@sonic:~$ sudo config interface type Ethernet0 XGMII
Setting RJ45 ports' type is not supported

admin@sonic:~$ sudo config interface advertised-type Ethernet0 XGMII
Setting RJ45 ports' advertised types is not supported

Mock table depends on PR #2110

How I did it

Check port type in the command, if RJ45 port then exit with not supported print out.

How to verify it

run above command on platforms with RJ45 ports

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs
Copy link
Collaborator

Test failure are caused by dependent mock dbs in #2110 has not yet been merged.

@prgeor
Copy link
Contributor

prgeor commented Apr 18, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants