[load_minigraph] Reuse updategraph service to load minigraph in cli #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taoyl-ms
changed the title
lguohan
approved these changes
Mar 15, 2018
jleveque
suggested changes
Mar 16, 2018
| _restart_services() | ||
| print "Please note setting loaded from minigraph will be lost after system reboot. To preserve setting, run `config save`." | ||
| run_command('sed -i "/enabled=/d" /etc/sonic/updategraph.conf', display_cmd=True) | ||
| run_command('echo enabled=reload_only /etc/sonic/updategraph.conf', display_cmd=True) |
There was a problem hiding this comment.
I believe you're missing a redirect operator here (either echo enabled=reload_only > /etc/sonic/updategraph.conf or echo enabled=reload_only >> /etc/sonic/updategraph.conf). I believe you intended to append.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
60f5237 (HEAD, origin/202012) [multi-asic]: Udpate to use SonicDBConfig from swsscommon (sonic-net#219) 5c0d941 [201911][RFC1213]: Initialize lag oid map in reinit_data (sonic-net#234) Signed-off-by: Suvarna Meenakshi <sumeenak@microsoft.com>
mihirpat1
pushed a commit
to mihirpat1/sonic-utilities
that referenced
this pull request
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
As new
updategraphservice in sonic-net/sonic-buildimage#1452 support reloading minigraph, reuse the logic in CLI to avoid explicitly restart depending service in CLI code.