Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add W-ECMP CLI #3253

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Add W-ECMP CLI #3253

merged 4 commits into from
Jun 5, 2024

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Apr 2, 2024

HLD: sonic-net/SONiC#1629

What I did

  • Implemented CLI for Weighted-Cost Multi-Path feature

How I did it

  • Integrated Weighted-Cost Multi-Path interface into config and show CLI root

How to verify it

  1. Run Weighted-Cost Multi-Path CLI UTs

Previous command output (if the output of a command-line utility has changed)

  • N/A

New command output (if the output of a command-line utility has changed)

admin@sonic:/home/admin# show bgp device-global
TSA      WCMP
-------  -------
enabled  enabled
admin@sonic:/home/admin# show bgp device-global --json
{
    "tsa": "enabled",
    "wcmp": "enabled"
}

@liat-grozovik
Copy link
Collaborator

@venkatmahalingam would you mind to provide code PR review feedback as well?

@liat-grozovik liat-grozovik changed the title [wcmp]: Add WCMP CLI Add W-ECMP CLI May 22, 2024
@tjchadaga
Copy link
Contributor

@nazariig - what is the expected output of the CLI on a multi-asic device?

@tjchadaga
Copy link
Contributor

@nazariig - could you please clarify why TSA and WCMP are combined here, instead of a CLI dedicated to WCMP?

@nazariig
Copy link
Collaborator Author

@nazariig - what is the expected output of the CLI on a multi-asic device?

@tjchadaga multi-asic is out of scope

@nazariig
Copy link
Collaborator Author

nazariig commented May 22, 2024

@nazariig - could you please clarify why TSA and WCMP are combined here, instead of a CLI dedicated to WCMP?

@tjchadaga they use the same configuration key and both are global features, so were put on the same table.

@tjchadaga
Copy link
Contributor

@nazariig - could you please clarify why TSA and WCMP are combined here, instead of a CLI dedicated to WCMP?

@tjchadaga they use the same configuration key and both are global features, so were put on the same table.

@nazariig - would this CLI output need to be updated each time new bgp global features are added?

@nazariig
Copy link
Collaborator Author

@nazariig - could you please clarify why TSA and WCMP are combined here, instead of a CLI dedicated to WCMP?

@tjchadaga they use the same configuration key and both are global features, so were put on the same table.

@nazariig - would this CLI output need to be updated each time new bgp global features are added?

@tjchadaga if the original YANG model is going to be reused and extended - the answer is yes

nazariig added 2 commits May 23, 2024 19:20
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@nazariig nazariig force-pushed the master-wcmp branch 5 times, most recently from 468910f to 1bd3020 Compare May 23, 2024 18:47
nazariig added 2 commits May 23, 2024 22:34
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@tjchadaga tjchadaga merged commit 6829ded into sonic-net:master Jun 5, 2024
7 checks passed
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
* [wcmp]: Add WCMP CLI.

Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants