-
Notifications
You must be signed in to change notification settings - Fork 670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add W-ECMP CLI #3253
Add W-ECMP CLI #3253
Conversation
@venkatmahalingam would you mind to provide code PR review feedback as well? |
@nazariig - what is the expected output of the CLI on a multi-asic device? |
@nazariig - could you please clarify why TSA and WCMP are combined here, instead of a CLI dedicated to WCMP? |
@tjchadaga multi-asic is out of scope |
@tjchadaga they use the same configuration key and both are global features, so were put on the same table. |
@nazariig - would this CLI output need to be updated each time new bgp global features are added? |
@tjchadaga if the original YANG model is going to be reused and extended - the answer is yes |
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
468910f
to
1bd3020
Compare
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
* [wcmp]: Add WCMP CLI. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
HLD: sonic-net/SONiC#1629
What I did
How I did it
config
andshow
CLI rootHow to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)