Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Voq Counters(SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP,SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS) for Voq/Fabric switches #3322

Merged
merged 7 commits into from
Jun 5, 2024
Merged

Added support for Voq Counters(SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP,SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS) for Voq/Fabric switches #3322

merged 7 commits into from
Jun 5, 2024

Conversation

saksarav-nokia
Copy link
Contributor

What I did

Added cli support to show SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP counter in show dropcounter counts command and show SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS counters in show queue counter --voq command.

How I did it

 Modified the dropstat and queuestat cli commands to show these new counters

How to verify it

Simulated the Packet integrity (CRC, RQP errors) and Credit Watchdog delete drops (disabled the TX for the ports and simulated the credit watchdog deletes) and verified that the show commands are showing the correct output from COUNTERS_DB.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

1)show dropcounter counts
2)show queue counter --voq

@saksarav-nokia
Added support for Voq Counters(SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP,…
6bbea96 
… SAI_QUEUE_ST�T_CREDIT_WD_DELETED_PACKETS) for Voq/Fabric switches

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@saksarav-nokia saksarav-nokia force-pushed the saksarav-nokia-voq-counters branch from 1a2c6df to 6bbea96 Compare May 15, 2024 15:55
@saksarav-nokia
Copy link
Contributor Author

@rlhui , please review it

@saksarav-nokia saksarav-nokia mentioned this pull request May 15, 2024
Merged
@saksarav-nokia
Copy link
Contributor Author

sonic-net/sonic-swss#3152 has the corresponding orchagent changes.

@saksarav-nokia saksarav-nokia force-pushed the saksarav-nokia-voq-counters branch 2 times, most recently from b8a2ab0 to bbd6eb8 Compare May 16, 2024 19:11
@saksarav-nokia
Fix the vs test failures
aef25a0 
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@saksarav-nokia saksarav-nokia force-pushed the saksarav-nokia-voq-counters branch 4 times, most recently from 38b9984 to 6916c23 Compare May 21, 2024 02:03
@saksarav-nokia
Add Packet Integrity drop counter to mock-table counters_db for code …
40a43ea 
…coverage

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@saksarav-nokia saksarav-nokia force-pushed the saksarav-nokia-voq-counters branch from 6916c23 to 40a43ea Compare May 21, 2024 14:35
@saksarav-nokia
Fix the pre-commit check failures
e124bff 
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@saksarav-nokia saksarav-nokia force-pushed the saksarav-nokia-voq-counters branch from c672248 to e124bff Compare May 21, 2024 18:31
@vmittal-msft vmittal-msft self-requested a review May 25, 2024 22:08
@vmittal-msft vmittal-msft self-assigned this May 25, 2024
@vmittal-msft
Copy link
Contributor

@saksarav-nokia Can you please share o/p for both commands ?

@vmittal-msft
Copy link
Contributor

Also, we may need to check on T0/T1 to make sure these changes don't break anything there.

vmittal-msft
vmittal-msft reviewed May 25, 2024
View reviewed changes
Copy link
Contributor

@vmittal-msft vmittal-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented above

@saksarav-nokia
Copy link
Contributor Author

Vineet, Here is the output of the show commands
admin@ixre-egl-board29:~$ sudo ip netns exec asic0 show queue counters --voq
Port Voq Counter/pkts Counter/bytes Drop/pkts Drop/bytes Credit-WD-Del/pkts

ixre-egl-board29|asic0|Cpu0 VOQ0 6 720 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ1 0 0 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ2 0 0 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ3 0 0 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ4 1027 194875 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ5 0 0 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ6 0 0 0 0 0
ixre-egl-board29|asic0|Cpu0 VOQ7 0 0 0 0 0

                        Port    Voq    Counter/pkts    Counter/bytes    Drop/pkts    Drop/bytes    Credit-WD-Del/pkts

ixre-egl-board29|asic0|Ethernet0 VOQ0 0 0 0 0 0
ixre-egl-board29|asic0|Ethernet0 VOQ1 0 0 0 0 0
ixre-egl-board29|asic0|Ethernet0 VOQ2 0 0 0 0 0
ixre-egl-board29|asic0|Ethernet0 VOQ3 0 0 0 0 5
ixre-egl-board29|asic0|Ethernet0 VOQ4 0 0 0 0 0
ixre-egl-board29|asic0|Ethernet0 VOQ5 0 0 0 0 0
ixre-egl-board29|asic0|Ethernet0 VOQ6 0 0 0 0 0
ixre-egl-board29|asic0|Ethernet0 VOQ7 0 0 0 0 0

admin@ixre-egl-board29:~$ sudo ip netns exec asic1 show dropcounters counts
SWITCH LEVEL COUNTERS:
SWITCH-ID PKT_INTEGRITY_ERR

      2                   4

    IFACE    STATE    RX_ERR    RX_DROPS    TX_ERR    TX_DROPS

Ethernet0        X         0           0         0           0
Ethernet8        X         0           0         0           0

Ethernet16 X 0 0 0 0
Ethernet24 X 0 0 0 0
Ethernet32 X 0 0 0 0
Ethernet40 X 0 0 0 0
Ethernet48 U 0 5 0 0
Ethernet56 X 0 0 0 0
Ethernet64 X 0 0 0 0
Ethernet72 X 0 0 0 0
Ethernet80 U 0 0 0 0
Ethernet88 X 0 0 0 0
Ethernet96 X 0 0 0 0
Ethernet104 X 0 0 0 0
Ethernet112 U 0 1 0 0
Ethernet120 X 0 0 0 0
Ethernet128 X 0 0 0 0
Ethernet136 X 0 0 0 0
Ethernet-IB0 U 0 0 0 0
Ethernet-Rec0 U 0 0 0 0

@saksarav-nokia
Copy link
Contributor Author

In the supervisor:
admin@ixre-cpm-chassis14:~$ sudo ip netns exec asic8 show dropcounters counts
SWITCH LEVEL COUNTERS:
SWITCH-ID PKT_INTEGRITY_ERR

      8                 5961

@saksarav-nokia
Copy link
Contributor Author

Also, we may need to check on T0/T1 to make sure these changes don't break anything there.

Also, we may need to check on T0/T1 to make sure these changes don't break anything there.

I will add a check for switch_type as fabric or voq.

@saksarav-nokia
Copy link
Contributor Author

saksarav-nokia commented May 28, 2024 •
edited
Loading

queue counters output with voq credit-watchdog deleted counters
image

@saksarav-nokia
Copy link
Contributor Author

saksarav-nokia commented May 28, 2024 •
edited
Loading

drop counters with packet integrity counters in IMM
image

@saksarav-nokia
Copy link
Contributor Author

saksarav-nokia commented May 28, 2024 •
edited
Loading

drop counters with packet integrity counters in SUP
image

@saksarav-nokia
Add check to print the switch voq drop counters only for chassis
cd9517e 
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@saksarav-nokia saksarav-nokia force-pushed the saksarav-nokia-voq-counters branch from 2e4db3b to cd9517e Compare May 28, 2024 20:45
@vmittal-msft
Copy link
Contributor

drop counters with packet integrity counters in IMM image

@saksarav-nokia Can you please change to name of switch type to VoQ

or may be we can remove first 2 lines - switch type and switch level

@saksarav-nokia
Copy link
Contributor Author

drop counters with packet integrity counters in IMM image

@saksarav-nokia Can you please change to name of switch type to VoQ

or may be we can remove first 2 lines - switch type and switch level

switch type is already removed. Don't you think having switch level helps the user?

@vmittal-msft
Copy link
Contributor

please add heading as "switch counters" and "interface counters".

@saksarav-nokia
Addressed review comments - Removed "SWITCH LEVEL COUNTERS"
7491198 
Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@arlakshm arlakshm merged commit 4133ef5 into sonic-net:master Jun 5, 2024
7 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-utilities that referenced this pull request Jun 12, 2024
@saksarav-nokia @mssonicbld
[chassis][voq] Added support for Voq Counters(SAI_SWITCH_STAT_PACKET_…
bb1441b 
…INTEGRITY_DROP,SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS) for Voq/Fabric switches (sonic-net#3322)

What I did
Added cli support to show SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP counter in show dropcounter counts command and show SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS counters in show queue counter --voq command.

How I did it
 Modified the dropstat and queuestat cli commands to show these new counters 
How to verify it
Simulated the Packet integrity (CRC, RQP errors) and Credit Watchdog delete drops (disabled the TX for the ports and simulated the credit watchdog deletes) and verified that the show commands are showing the correct output from COUNTERS_DB.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
1)show dropcounter counts
2)show queue counter --voq

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@mssonicbld mssonicbld mentioned this pull request Jun 12, 2024
Merged
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
@saksarav-nokia @arfeigin
[chassis][voq] Added support for Voq Counters(SAI_SWITCH_STAT_PACKET_…
6fdf8a3 
…INTEGRITY_DROP,SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS) for Voq/Fabric switches (sonic-net#3322)

What I did
Added cli support to show SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP counter in show dropcounter counts command and show SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS counters in show queue counter --voq command.

How I did it
 Modified the dropstat and queuestat cli commands to show these new counters 
How to verify it
Simulated the Packet integrity (CRC, RQP errors) and Credit Watchdog delete drops (disabled the TX for the ports and simulated the credit watchdog deletes) and verified that the show commands are showing the correct output from COUNTERS_DB.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
1)show dropcounter counts
2)show queue counter --voq

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

5 similar comments
@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!!
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3366

3 similar comments
@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3366

@mssonicbld
Copy link
Collaborator

@saksarav-nokia cherry pick PR didn't pass PR checker. Please check!!! Auto cherry pick PR will be closed in 3 days.
#3366

mssonicbld pushed a commit that referenced this pull request Jul 12, 2024
@saksarav-nokia @mssonicbld
[chassis][voq] Added support for Voq Counters(SAI_SWITCH_STAT_PACKET_…
493212a 
…INTEGRITY_DROP,SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS) for Voq/Fabric switches (#3322)

What I did
Added cli support to show SAI_SWITCH_STAT_PACKET_INTEGRITY_DROP counter in show dropcounter counts command and show SAI_QUEUE_STAT_CREDIT_WD_DELETED_PACKETS counters in show queue counter --voq command.

How I did it
 Modified the dropstat and queuestat cli commands to show these new counters 
How to verify it
Simulated the Packet integrity (CRC, RQP errors) and Credit Watchdog delete drops (disabled the TX for the ports and simulated the credit watchdog deletes) and verified that the show commands are showing the correct output from COUNTERS_DB.

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)
1)show dropcounter counts
2)show queue counter --voq

Signed-off-by: saksarav <sakthivadivu.saravanaraj@nokia.com>
@vikshaw-Nokia vikshaw-Nokia mentioned this pull request Aug 1, 2024
Closed
8 tasks
This was referenced Dec 18, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vmittal-msft vmittal-msft vmittal-msft approved these changes

Assignees

@vmittal-msft vmittal-msft

Labels
Approved for 202405 Branch Chassis Included in 202405 Branch Request for 202405 Branch
Projects
SONiC Chassis
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@saksarav-nokia @vmittal-msft @mssonicbld @arlakshm @bingwang-ms