[multi-asic]: Update reload of systemd services to support multi-asic platforms #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to support multi-asic platforms.
lguohan
reviewed
Mar 24, 2020
config/main.py
Outdated
| except SystemExit as e: | ||
| log_error("Restart {} failed with error {}".format(service, e)) | ||
| raise | ||
| if ((service + '.service' in generated_services_list) or |
There was a problem hiding this comment.
duplicated code as above. please use function to reduce the duplicated code.
There was a problem hiding this comment.
looks like the code is duplicated three times
There was a problem hiding this comment.
updated code as per comment.
jleveque
previously approved these changes
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
config/main.py
Outdated
| except SystemExit as e: | ||
| log_error("Stopping {} failed with error {}".format(service, e)) | ||
| raise | ||
| execute_systemctl(services_to_stop, SYSTEMCTL_STOP) |
There was a problem hiding this comment.
please check the return results and act accordingly.
There was a problem hiding this comment.
execute_systemctl() - this function prints error message or handles exception itself, should we further get return value and act?
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 25, 2020
lguohan
reviewed
Mar 25, 2020
lguohan
reviewed
Mar 25, 2020
judyjoseph
reviewed
Mar 25, 2020
services to ensure that the right instances are stopped and restarted if a service is both global and multi-instance.
lguohan
previously approved these changes
Mar 25, 2020
judyjoseph
previously approved these changes
Mar 25, 2020
SuvarnaMeenakshi
dismissed stale reviews from judyjoseph and lguohan
via
f2959ca
judyjoseph
approved these changes
Mar 25, 2020
lguohan
approved these changes
Mar 25, 2020
jleveque
approved these changes
Mar 25, 2020
rlhui
pushed a commit
that referenced
this pull request
Mar 30, 2020
… platforms (#856) * Update stop, reset failed status and restart of systemd services to support multi-asic platforms. * Create function to avoid code duplication. * Fixed errors due to pervious commit and review comments. * Minor update to fix spacing. * Minor update to fix spacing. * Minor update to fix spacing. * For multi asic platform updated logic of stopping/restarting of services to ensure that the right instances are stopped and restarted if a service is both global and multi-instance. * Fixed log error message with incorrect number of parameterts.
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
… platforms (sonic-net#856) * Update stop, reset failed status and restart of systemd services to support multi-asic platforms. * Create function to avoid code duplication. * Fixed errors due to pervious commit and review comments. * Minor update to fix spacing. * Minor update to fix spacing. * Minor update to fix spacing. * For multi asic platform updated logic of stopping/restarting of services to ensure that the right instances are stopped and restarted if a service is both global and multi-instance. * Fixed log error message with incorrect number of parameterts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
For multi-asic platform, there can be multiple instances of some systemd services. currently config reload CLI stops and restarts only single instance of systemd service.
Modified stop/reset failed-status and restart system services function to perform action on multiple instances of systemd services.
- How I did it
- How to verify it
Bring up a single ASIC VS image.
Load config_db.json/minigraph.xml
Update config_db.json or load a new config_db.json.
Do a "config reload".
Verify that all required services are stopped and restarted.
Verify all services are up.
Verify if the configuration/interfaces of previous configuration is completely removed and new configuration is applied.
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)