Added deterministic flow seq for SFF transceivers #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added deterministic flow seq for SFF transceivers based on the reasons mentioned in 'Plan' section
|
|
prgeor
reviewed
Oct 18, 2023
| # SFF compliant transceiver initialization | ||
| 1. Add new flag 'skip_non_cmis_mgr' and platform/hwsku to set this appropriately indicating whether it's supporting determinstic link bring-up sequence (per this document) or not. Default to be set to true for SFF (i.e. non-CMIS) compliant transeivers | ||
| 2. xcvrd to do the following as part of its main thread (for initialization/boot-up/restart scenarios) | ||
| - Spawn a new worker thread SFFManagerTask() to handle SFF (aka non-CMIS) transceivers (optical modules) |
There was a problem hiding this comment.
@shyam77git can we have a separate HLD for SFF manager where you can list the objectives:-
- Deterministic link bring up for SFF compliant transceivers
- Custom SI settings
- Enabling High power mode for optics like 100G-DR4
prgeor
reviewed
Oct 18, 2023
There was a problem hiding this comment.
@shyam77git Also please use new path for the doc file may be:-
doc/sfp-sff/sfp-manager.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added deterministic flow seq for SFF transceivers based on the reasons mentioned in 'Plan' section