Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gNSI - gRPC Network Security Interface HLD #1557

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

rlucus
Copy link
Contributor

@rlucus rlucus commented Dec 14, 2023

https://github.com/openconfig/gnsi/tree/main/

gNSI adds a group of microservices that manage changing security elements of various types. (tls/ssh/grpc, etc)

@rlucus rlucus marked this pull request as draft March 28, 2024 22:35
@rlucus rlucus changed the title gNSI Certz hld gNSI - gRPC Network Security Interface HLD Jun 26, 2024
@zhangyanzhao zhangyanzhao requested a review from qiluo-msft June 26, 2024 15:44
@rlucus rlucus marked this pull request as ready for review June 26, 2024 15:56
@qiluo-msft qiluo-msft requested review from isabelmsft and ganglyu June 27, 2024 02:07
Copy link

@hdwhdw hdwhdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM. Just need some clarification.

doc/mgmt/gnmi/images/gnsi_certz_rotate.png Outdated Show resolved Hide resolved
doc/mgmt/gnmi/gnsi.md Outdated Show resolved Hide resolved
doc/mgmt/gnmi/gnsi.md Show resolved Hide resolved
doc/mgmt/gnmi/gnsi.md Show resolved Hide resolved
doc/mgmt/gnmi/gnsi.md Show resolved Hide resolved
@rlucus rlucus requested review from hdwhdw and qiluo-msft November 20, 2024 18:56
Copy link

@hdwhdw hdwhdw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@bhagatgit bhagatgit merged commit 86359c4 into sonic-net:master Nov 22, 2024
1 check passed
@bhagatgit
Copy link
Contributor

Merging as we have received approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants