PoE design proposal HLD document #1631

plvisiondevs · 2024-03-11T21:28:32Z

Add PoE design proposal HLD document with the following content:

Requirements
Component interactions
DB table definition
CLI

In order to isolate PoE functionality and complexity from existing SONiC design, the following main changes are made:

Add separate container for PoE control plane routine operations.
Introduce separate SYNCD container to support external PoE Abstraction Interface.
Add new PoE tables into database container.

SAI community changes #1977

Signed-off-by: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>

linux-foundation-easycla · 2024-03-11T21:28:36Z

The committers listed above are authorized under a signed CLA.

✅ login: vmytnyk-plv / name: Volodymyr Mytnyk (02a534d, 29a57f9)

zhangyanzhao · 2024-03-26T15:05:17Z

community review recording https://zoom.us/rec/share/Rx4P62u1hfWkAH2kMgyIP-SoWcQfeQrkgM3hvuv8AsMjNJMWQT70dBOcx6GqmnXe.52gMDrInKWQmT0E4

kishorgovind · 2024-03-28T06:08:21Z

Design is not according to SONiC design philosophy. Without significant requirement or necessity another syncD has been added for POE. Multiple syncD module in SONiC architecture is not a SONiC design philosophy. Also PoE is a hardware feature i.e. feature attached to physical interface and not related to ASIC forwarding. Hence using syncD module for management of this feature is not a right way of feature designing in SONiC. Here we have to follow management POE feature same way how PMON manages fan and power using PDDF framework. In recording team was mentioning about performance impact if we use PDDF framework but I could not get right justification.

- add SWSS cahnges - include LLDP interaction - add example PoE config - mention about warm reboot requirements Signed-off-by: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>

kishorgovind · 2024-04-03T11:46:46Z

My review comment is not addressed yet.

taraschornyiplv · 2024-04-03T16:51:10Z

Design is not according to SONiC design philosophy. Without significant requirement or necessity another syncD has been added for POE. Multiple syncD module in SONiC architecture is not a SONiC design philosophy. Also PoE is a hardware feature i.e. feature attached to physical interface and not related to ASIC forwarding. Hence using syncD module for management of this feature is not a right way of feature designing in SONiC. Here we have to follow management POE feature same way how PMON manages fan and power using PDDF framework. In recording team was mentioning about performance impact if we use PDDF framework but I could not get right justification.

We want to utilize SAI as the standard API for PoE. This will allow PoE chip vendors to provide SAI library for their PoE devices. Usually, NPU and PoE chips are from different vendors, thus a need for a separate syncd container.
Also in SONiC multiple syncd containers are already available to support PHY chips.

RogerX87 · 2024-04-12T08:22:16Z

Is there any plan about SNMP? I think SNMP can also control the PoE.

zhangyanzhao · 2024-04-26T23:29:55Z

Can we also have the code PRs listed in this HLD PR? Thanks.

lguohan · 2024-04-29T22:01:42Z

doc/poe/poe_hld.md

+
+#### PoE SYNCD
+
+New PoE SYNCD container componnents:


what is the reason to have a poe syncd? why normal syncd won't work. isn't that poe feature is captured with SAI api, then normal syncd can support poe as long as the sai library support poe?

I believe the motivation is to allow use of an additional instance of SAI. one for NPU and one for PoE. This is assuming that NPU and PoE HW and drivers are developed by different vendors

lguohan · 2024-04-29T22:02:50Z

doc/poe/poe_hld.md

+
+### PoE Abstraction Interface
+
+The PoE Manager uses a new SAI PoE library that implements the PoE Abstraction Interface.


can you share the poe sai library pr? is it already merged in sai?

SAI PR -opencomputeproject/SAI#1977 (merged)
Implementation will be (PoE HW) vendor specific, we will be providing an example, working implementation for MicroChip PSE (in development)

adyeung · 2024-05-15T21:06:59Z

@rk946043 pls help review

rk946043 · 2024-05-24T11:41:11Z

doc/poe/poe_hld.md

+
+In order to isolate PoE functionality and complexity from existing SONiC design, the following main changes are made:
+
+- Add separate container for PoE control plane routine configuration.


How this design address the platform dependencies?
Since there is a separate docker/container for the PoE, How this can resolve the platform dependencies like the dynamic detection of PSU and their power budget etc.

There are 2 options here:

HW - depends on the HW design.

SW - the PoE config manager could subscribe to the PSE-related events and during SAI PoE library initialization (power budget configuration).

saravanan-i · 2024-06-10T16:13:38Z

doc/poe/poe_hld.md

+### Memory Consumption
+This sub-section covers the memory consumption analysis for the new feature: no memory consumption is expected when the feature is disabled via compilation and no growing memory consumption while feature is disabled by configuration. 
+
+### Restrictions/Limitations  


Can you please confirm if we support Legacy PDs ? If not please capture them in Limitations

The control plane does not limit the support of the "Legacy PDs" according to SAI PoE definitions.

saravanan-i · 2024-06-10T16:19:47Z

doc/poe/poe_hld.md

+    current     = 1*3.3DIGIT              ; the current of the PoE port
+
+
+### Warmboot and Fastboot Design Impact  


Please capture if we are planning to support persistent supply of power to PD from PSE during reboot.

It's already in the current design.

saravanan-i · 2024-06-10T16:21:04Z

doc/poe/poe_hld.md

+    key         = POE_PORT|ifname         ; ifname with prefix POE_PORT
+    ; field     = value
+    enabled     = "enable" / "disable"    ; enable/disable PoE on port, default "disable"
+    power_limit = 1*3.1DIGIT              ; power limit on PoE port


Please confirm whether power budget will get updated when the PSU gets removed from the switch. Whether this will be taken care by the hardware ?

Typically it is done by the HW, from the SW point of view we just need to initialize the power banks.

SerhiyBoikoPLV · 2024-11-25T13:00:26Z

Is there any plan about SNMP? I think SNMP can also control the PoE.

The current design does not limit this, all the PoE-related configurations and states are reflected on Redis DB, so it could be extended to support the SNMP.

zhangyanzhao · 2024-12-10T05:32:07Z

code PRs can be found from sonic-net/sonic-buildimage#19636

zhangyanzhao · 2024-12-10T05:32:55Z

PRs are not merged yet, move to backlog

Add PoE SONiC design draft document

02a534d

Signed-off-by: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>

taraschornyiplv mentioned this pull request Mar 21, 2024

Power over Ethernet (PoE) #1539

Closed

Address review comments 03-26-2024

29a57f9

- add SWSS cahnges - include LLDP interaction - add example PoE config - mention about warm reboot requirements Signed-off-by: Volodymyr Mytnyk <volodymyr.mytnyk@plvision.eu>

zhangyanzhao requested a review from kishorgovind April 23, 2024 20:52

lguohan reviewed Apr 29, 2024

View reviewed changes

rk946043 reviewed May 24, 2024

View reviewed changes

madhupalu requested a review from adyeung June 10, 2024 16:09

saravanan-i reviewed Jun 10, 2024

View reviewed changes

SerhiyBoikoPLV mentioned this pull request Jul 19, 2024

[buildimage] Add support for PoE feature sonic-net/sonic-buildimage#19636

Open

11 tasks

SerhiyBoikoPLV mentioned this pull request Dec 3, 2024

[yang] Add yang model for POE_PORT sonic-net/sonic-buildimage#21005

Open

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

PoE design proposal HLD document #1631

PoE design proposal HLD document #1631

plvisiondevs commented Mar 11, 2024

linux-foundation-easycla bot commented Mar 11, 2024 •

edited

Loading

zhangyanzhao commented Mar 26, 2024

kishorgovind commented Mar 28, 2024

kishorgovind commented Apr 3, 2024

taraschornyiplv commented Apr 3, 2024 •

edited

Loading

RogerX87 commented Apr 12, 2024 •

edited

Loading

zhangyanzhao commented Apr 26, 2024

lguohan Apr 29, 2024

matiAlfaro May 2, 2024

lguohan Apr 29, 2024

matiAlfaro May 2, 2024

adyeung commented May 15, 2024

rk946043 May 24, 2024

SerhiyBoikoPLV Nov 25, 2024

saravanan-i Jun 10, 2024

SerhiyBoikoPLV Nov 25, 2024

saravanan-i Jun 10, 2024

SerhiyBoikoPLV Nov 25, 2024

saravanan-i Jun 10, 2024

SerhiyBoikoPLV Nov 25, 2024

SerhiyBoikoPLV commented Nov 25, 2024

zhangyanzhao commented Dec 10, 2024

zhangyanzhao commented Dec 10, 2024


		### PoE Abstraction Interface

		The PoE Manager uses a new SAI PoE library that implements the PoE Abstraction Interface.


		In order to isolate PoE functionality and complexity from existing SONiC design, the following main changes are made:

		- Add separate container for PoE control plane routine configuration.

		current = 1*3.3DIGIT ; the current of the PoE port


		### Warmboot and Fastboot Design Impact

PoE design proposal HLD document #1631

Are you sure you want to change the base?

PoE design proposal HLD document #1631

Conversation

plvisiondevs commented Mar 11, 2024

linux-foundation-easycla bot commented Mar 11, 2024 • edited Loading

zhangyanzhao commented Mar 26, 2024

kishorgovind commented Mar 28, 2024

kishorgovind commented Apr 3, 2024

taraschornyiplv commented Apr 3, 2024 • edited Loading

RogerX87 commented Apr 12, 2024 • edited Loading

zhangyanzhao commented Apr 26, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

adyeung commented May 15, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SerhiyBoikoPLV commented Nov 25, 2024

zhangyanzhao commented Dec 10, 2024

zhangyanzhao commented Dec 10, 2024

linux-foundation-easycla bot commented Mar 11, 2024 •

edited

Loading

taraschornyiplv commented Apr 3, 2024 •

edited

Loading

RogerX87 commented Apr 12, 2024 •

edited

Loading