Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L2 vxlan HLD #376

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

L2 vxlan HLD #376

wants to merge 9 commits into from

Conversation

shine4chen
Copy link
Contributor

@shine4chen shine4chen commented Apr 25, 2019

MSFT has implement basic L3 vxlan in vnet scenario. Here we add L2 vxlan based on their work.

prsunny and others added 9 commits October 18, 2018 08:43
High level design for Sonic Vxlan
* [watremark] Add watermark HLD

Signed-off-by: Mykola Faryma <mykolaf@mellanox.com>
Added a direct link for Slack discussion group for more comfortable UX
Signed-off-by: shine <shine.chen@nephosinc.com>
@shine4chen
Copy link
Contributor Author

@jianjundong

Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide few example configuration and the kernel configurations. Also, provide the delete sequence and any inter-dependency.


In layer 2 Vxlan, the tunnel map is VLAN to VNI. Layer 2 Vxlan is not supported completely, current state is TBD(To Be Done). The mainly shortcomings of L2 Vxlan are:

- Not specify the encap type when creating tunnel; The encap type is MAP_TO_INVALID, must be VLAN_ID_TO_VNI.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be we should add a role attribute to config_db entry, "encap_decap", "encap_only" or "decap_only". Currently there is a use-case for L2 Vxlan as "decap_only" tunnels and hence MAP_TO_INVALID


**Notice: The flows represented by red arrow are newly added by this project.**

- Flow 1:vxlanmgrd reads VXLAN related configuration from CONFIG_DB, creates VXLAN tunnel and its bridge portsave parameters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have the flow in UML sequence for clarity? Please refer Vxlan HLD.


- When creating vxlan tunnel, create its bridge port. If VXLAN tunnel without bridge port, FDB MAC can not be learnt from or set to VXLAN tunnel in ASIC.
- Add the tunnel name map to counter table, so that the ‘show mac’ command can display the FDB learnt from VXLAN tunnel.
- Send command to Linux kernel to create L2 VXLAN tunnel interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would BUM Forwarding of Vxlan Tunnel be supported?

@prsunny
Copy link
Contributor

prsunny commented Oct 15, 2020

We have another HLD that covers EVPN and L2 Vxlan - #437. This document is slightly out of scope.

@yxieca yxieca force-pushed the master branch 2 times, most recently from 8498931 to 8837dc2 Compare April 15, 2022 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants