add design doc for grpc_client #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prsunny
reviewed
Apr 3, 2022
doc/grpc_client/design_doc.md
Outdated
| and do this within SONiC PMON docker | ||
|
|
||
|
|
||
| Challenge: to provide an interface for gRPC daemon to exchange RPC's with the gRPC server running on the SoC |
There was a problem hiding this comment.
Please follow the other templates and have this as part of "Requirement" section
doc/grpc_client/design_doc.md
Outdated
| ``` | ||
| sudo ip route add <soc IP> via <vlan IP> src <Loopback IP> | ||
| ``` | ||
| - Te issue with adding a Kernel Route is the route_cheker will fail for this, since vlan IP is the HOST's own vlan IP within SONiC as such no real neighbor is present |
doc/grpc_client/design_doc.md
Outdated
| sudo ip route add <soc IP> via <vlan IP> src <Loopback IP> | ||
| ``` | ||
| - Te issue with adding a Kernel Route is the route_cheker will fail for this, since vlan IP is the HOST's own vlan IP within SONiC as such no real neighbor is present | ||
| - SWSS orchagent will complain about not able to istall the entry in ASIC, the entry will be present in APP DB but not present inside ASIC. This would deem more worarounds necessary to be able to use this approach. |
There was a problem hiding this comment.
install - typo. Please fix typos in the doc.. I see it it multiple places
doc/grpc_client/design_doc.md
Outdated
| LINKMGR_CABLE|PORTNAME | ||
| soc_ipv4: <soc IP> | ||
| ``` | ||
| - The update_control_plane_nat_acls in caclmgrd will look for the above configuration and upon getting the config, it will add the POSTROUTING nat rules |
There was a problem hiding this comment.
Please specify what NAT rules are installed currently and if it has any dependencies. How about restarting caclmgrd? Please capture in the doc
doc/grpc_client/design_doc.md
Outdated
| #### Rationale | ||
|
|
||
|
|
||
| - This approach would add the rule for all the soc IP's contained to DualToR, and SoC server and gRPC client would be able to communicate over agreed IP |
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
lolyu
reviewed
Apr 6, 2022
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
yxieca
force-pushed
the
master
branch
2 times, most recently
from
8498931 to
8837dc2
Compare
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
vdahiya12
force-pushed
the
grpc_client
branch
from
bf36c84 to
d0fd386
Compare
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prgeor
reviewed
Mar 8, 2023
| | Rev | Date | Author | Change Description | | ||
| |:---:|:--------:|:---------------:|--------------------| | ||
| | 0.1 | 04/1/22 | Vaibhav Dahiya | Initial version | | ||
| | 0.2 | 02/1/22 | Vaibhav Dahiya | Make chnages to be shared to Core Team | |
There was a problem hiding this comment.
0.2 date shouldn't be the date after 0.1 MM:DD:YY ?
prgeor
reviewed
Mar 8, 2023
|
|
||
| ## Requirements | ||
|
|
||
| - provide a service/daemon in SONiC to run in DualToR mode, which can interact with Platform API as well interact with state machine(aka Linkmgr) and orchagent to provide capability for it to get/set Link State/Forwarding State etc. from SoC(gRPC server listening to the client) |
There was a problem hiding this comment.
isn't gRPC service running on PMON is stateless?
prgeor
reviewed
Mar 8, 2023
|
|
||
| HOST and FPGA functionality is explained in this diagram | ||
|
|
||
|  |
There was a problem hiding this comment.
What is the blue line X for within FPGA indicating?
There was a problem hiding this comment.
explained offline
prgeor
reviewed
Mar 8, 2023
Comment on lines
+170
to
+201
| - Ycabled would exchange data/state with orchagent and linkmgr with the following schema: | ||
|
|
||
| ``` | ||
| APP_DB | ||
| MUX_CABLE_TABLE| PORTNAME; written by linkmgrd react on orchagent | ||
| - state: active | standby | ||
| HW_ MUX_CABLE_TABLE | PORTNAME; written by orchagent react on ycabled (its replacement) | ||
| - state: active | standby | ||
| FORWARDING_STATE_COMMAND | PORTNAME: | ||
| - command: probe | set_active_self | set_standby_self | set_standby_peer ;written by linkmgrd react on ycabled | ||
| FORWARDING_STATE_RESPONSE | PORTNAME | ||
| - response: active | standby | unknown | error ;written by ycabled react by linkmgrd | ||
| - response_peer: active | standby | unknown | error ;written by ycabled react by linkmgrd | ||
| PORT_TABLE|PORTNAME | ||
| - oper_status: up|down; written by swss react by linkmgrd | ||
| PORT_TABLE_PEER|PORT | ||
| - oper_status: up|down; written by ycabled react by linkmgrd | ||
| HW_FORWARDING_STATE_PEER|PORTNAME; written by linkmgrd react by ycabled | ||
| - state: active|standby|unknown | ||
| MUX_SERVICE_NOTIFICATION|PORT | ||
| - notify_type:control/data | ||
| - msg_type:begin/end | ||
| - guid:<guid> | ||
| - service_time:<time> //seconds | ||
|
|
||
| STATE_DB | ||
| MUX_CABLE_TABLE| PORTNAME | ||
| - State: active|standby|unknown; written by orchagent react on linkmgrd | ||
| HW_MUX_CABLE_TABLE| PORTNAME | ||
| - State: acative|standby|unknown; written by ycabled react on orchagent | ||
| HW_MUX_CABLE_TABLE_PEER| PORTNAME | ||
| - state: active |standby|unknown; written by ycabled react on linkmgrd |
There was a problem hiding this comment.
How is this relavant to grpc?
There was a problem hiding this comment.
this section is just making this commensurate to our design doc
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
Signed-off-by: vaibhav-dahiya <vdahiya@microsoft.com>
prgeor
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaibhav-dahiya vdahiya@microsoft.com