data.azapi_resource does not handle 429 Too Many Requests

[tiwood]

We're using the provider to get a list of list of available service tags for our Azure Firewall automation (via https://management.azure.com/subscriptions/.../providers/Microsoft.Network/locations/westeurope/serviceTags. This API is rate limited, which is currently not handled by the provider.

  │ --------------------------------------------------------------------------------
  │ RESPONSE 429: 429 Too Many Requests
  │ ERROR CODE: RetryableError
  │ --------------------------------------------------------------------------------
  │ {
  │   "error": {
  │     "code": "RetryableError",
  │     "message": "A retryable error occurred.",
  │     "details": [
  │       {
  │         "code": "RetryableErrorDueToTooManyCallsToThisOperation",
  │         "message": "Operation GetServiceTagsOperation exceeded throttling limit of 5 calls within last 5 minutes. The number of calls exceeds Microsoft.Network throttling limit. The call can be retried in 76 seconds."
  │       }
  │     ]
  │   }
  │ }
  │ --------------------------------------------------------------------------------

I would expect that the provider handles these automatically, honoring the related rety-after headers.

[tiwood]

I've solved it via the retry argument:

  retry = {
    error_message_regex = ["A retryable error occurred."]
  }

If you ask me, I think retryable errors should be retried without any user configuration.

[matt-FFFFFF]

429 errors are handled by the Azure go sdk

https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azcore/runtime/policy_retry.go

@hqhqhqhqhqhqhqhqhqhqhq I think the default will retry 3 times on 429 errors.

Perhaps we should make sure we are using this policy?

[matt-FFFFFF]

In pr #745 I expose the underlying GO SDK's retry count.

This could be a solution to this?