Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README doesn't have a v3 example or explanation of the differences #388

Open
jsoref opened this issue Jan 5, 2024 · 4 comments
Open

README doesn't have a v3 example or explanation of the differences #388

jsoref opened this issue Jan 5, 2024 · 4 comments
Assignees

Comments

@jsoref
Copy link

jsoref commented Jan 5, 2024

All examples in README.md on the v3 branch as of now:

uses: azure/webapps-deploy@v2

- uses: azure/webapps-deploy@v2

- uses: azure/webapps-deploy@v2

Some thoughts about the 3.0.0 release notes:

Features

  • Ex: - type=war: Deploy a WAR package. By default, the WAR package is deployed to /home/site/wwwroot/app.war. The target path can be specified with parameter target-path.

-- it's unlikely this is formatted correctly.

Allowed values: true/false

should be written as:

Allowed values: true/false

Example

- name: Deploy to Azure Web App
  id: deploy-to-webapp
  uses: azure/webapps-deploy@v3
  with:
    app-name: ${{ env.AZURE_WEBAPP_NAME }}
    publish-profile: ${{ secrets.AZURE_WEBAPP_PUBLISH_PROFILE }}
    package: '*.war'
    type: (jar, war, zip, static)
    clean: (true, false)
    target-path: (i.e. /home/site/wwwroot/test, /home/site/wwwroot/test.war)
    restart: (true, false)

This example kinda relates to the original point -- something like this should be present in the readme. Ideally with a sample of a v2 workflow and an equivalent v3 workflow.

Copy link

This issue is idle because it has been open for 14 days with no activity.

@github-actions github-actions bot added the idle label Jan 19, 2024
@jsoref
Copy link
Author

jsoref commented Jan 19, 2024

@surenderssm is this repository alive?

@frederiktoft
Copy link

Just want to chime in and say this would be greatly appreciated. Struggling getting v3 to work.

@runxc1
Copy link

runxc1 commented Mar 22, 2024

v2 gives a warning currently so this should be bumped up to get users to convert to v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants