Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing documentation/comments about AAD long-lived bearer token #52

Open
cadi3s opened this issue May 21, 2021 · 2 comments
Open

Missing documentation/comments about AAD long-lived bearer token #52

cadi3s opened this issue May 21, 2021 · 2 comments
Labels
documentation Improvements or additions to documentation duplicate This issue or pull request already exists question Further information is requested

Comments

@cadi3s
Copy link

cadi3s commented May 21, 2021

The comments in ConfigureService for production say that you should not "rely on a token generated by Azure AD".
Is that comment correct?

The tutorial says that the only valid option for non-gallery apps is to use a long-lived bearer token.
I can create a JWT access_token to my SCIM API with 3 year expire date, and paste that in the Secret Token field. But that is just a glorified 'shared secret' - how is that safer than using the /scim/token development endpoint?

If I leave 'secret token' blank, at least I can verify the issuer in the AAD generated token and know that I am called from the correct Tenant, instead of having a fixed token that could be compromised.

NB my question is similar to issues #35 and #37 and Rickards post on SO. However the fact remains that ConfigureService in SCIMReferenceCode only contains code on how not to do things..

@rfolkes
Copy link

rfolkes commented Jun 22, 2021

Yes, been struggling with trying to understand how to turn this into a multi-tenant enabled solution. Creating a fixed token per AD tenant doesnt make sense.

Would not checking the issued Azure AD token be better than a long lived secret?

@marcusca10 marcusca10 added documentation Improvements or additions to documentation duplicate This issue or pull request already exists question Further information is requested labels Jan 19, 2022
@marcusca10
Copy link
Collaborator

Duplicate for #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation duplicate This issue or pull request already exists question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants