Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of path and pathless patch operations #97

Open
mshiels opened this issue Mar 21, 2024 · 1 comment
Open

Handling of path and pathless patch operations #97

mshiels opened this issue Mar 21, 2024 · 1 comment

Comments

@mshiels
Copy link

mshiels commented Mar 21, 2024

Happened to see some wso2 documentation on patch and decided to try the two operations against the reference code and the pathless variation just fails miserably, skipping the patch itself. Is this a known issue, when tracing through the code it just ends up doing a return at some point as something was missing it expected to be set.

pathless
{
"op": "add",
"value": {
"nickName": "shaggy"
}
}

pathed
{
"op": "add",
"path": "nickName",
"value": "Tomy"
}

@clifinthrive
Copy link

We have failed 3 validator tests due to not handling 'pathless' PATCH ops correctly in the reference code, for example:
{
"op": "replace",
"value": {
"active": true,
"displayName": "5CMEQTDIZTNHA",
"name.givenName": "5Madonna",
...
}
}

the code is in Core2EnterpriseUserExtensions::Apply(this Core2EnterpriseUser user, PatchRequest2 patch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants