Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndexSources TFS 2015 build step fails with Microsoft.IdentityModel.JsonWebTokens.pdb #1098

Closed
Saurbaum opened this issue Jan 22, 2019 · 6 comments
Assignees
Labels
Customer reported Indicates issue was opened by customer Investigate We are not quite sure what the issue is. P1 More important, prioritize highly
Milestone

Comments

@Saurbaum
Copy link

I'm seeing this in my overnight builds using the latest released build on nuget 5.3.0

Indexed source information could not be retrieved from d:\dev\Binaries\Win32\Release\Microsoft.IdentityModel.JsonWebTokens.pdb. Error: Symbol indexes could not be retrieved.

This is triggered before we publish our symbols to our server using https://msdn.microsoft.com/en-us/windows/desktop/microsoft.teamfoundation.build.workflow.activities.indexsources. and we are using Team Foundation Server 2015 Update 3.

If I'm reading this error message properly the pdb produced and packaged in nuget is made using a portable format. Can you confirm that is the case and is there anything I can do to get around the error?

@Saurbaum Saurbaum changed the title IndexSources TFS 2017 build step fails with Microsoft.IdentityModel.JsonWebTokens.pdb IndexSources TFS 2015 build step fails with Microsoft.IdentityModel.JsonWebTokens.pdb Jan 22, 2019
@brentschmaltz
Copy link
Member

@Saurbaum is this happening for any other assemblies?

@brentschmaltz brentschmaltz added Customer reported Indicates issue was opened by customer Investigate We are not quite sure what the issue is. labels Jan 22, 2019
@brentschmaltz brentschmaltz added this to the 5.4.1 milestone Jan 22, 2019
@Saurbaum
Copy link
Author

Saurbaum commented Jan 22, 2019

So far it's only that one but it's entirely possible that the rest of the IdentityModel assemblies have the same issue.

Unfortunately the Build step bails out on the first error so I'm unsure if it will affect the others.

@Saurbaum
Copy link
Author

If I'm right https://docs.microsoft.com/en-us/dotnet/standard/library-guidance/nuget#symbol-packages has the suggestions on how to distribute pdbs using nuget.

https://docs.microsoft.com/en-us/nuget/create-packages/symbol-packages-snupkg

That then keeps the pdbs out of the nuget package and away from the Index Sources build step.

@brentschmaltz
Copy link
Member

@Saurbaum we will try and get this into the next release.

@dozer75
Copy link

dozer75 commented Mar 11, 2019

Stumbled into the same issue today and searched quite a bit on the net before I found this issue here.

Anyway, during that search I found that this seems to be an issue with the fact that the pdb file delivered with the nuget package is portable even for .NET targets. Not all external tools (like Visual Studio 2015, .NET versions 4.7.1, symbol server) supports this (see portable information at the dotnet/core team).

So I think that the solution here is the solution referenced here. It seems to have fixed problem with their nuget package.

@GeoK GeoK self-assigned this Apr 29, 2019
@mafurman mafurman added the P1 More important, prioritize highly label May 1, 2019
@GeoK
Copy link
Member

GeoK commented May 17, 2019

@Saurbaum We are going to ship our .pdbs in separate .snupkg packages (#1172). This should unblock you.
@dozer75 Thank you for chiming in. You are right, portable PDBs are not supported everywhere but the main advantage is that they can be created and read on all platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer reported Indicates issue was opened by customer Investigate We are not quite sure what the issue is. P1 More important, prioritize highly
Projects
None yet
Development

No branches or pull requests

5 participants