Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Remove sync-over-async patterns in 7x. #2253

Closed
jennyf19 opened this issue Aug 24, 2023 · 2 comments · Fixed by #2263
Closed

[Bug] Remove sync-over-async patterns in 7x. #2253

jennyf19 opened this issue Aug 24, 2023 · 2 comments · Fixed by #2263
Assignees
@westin-m
Labels
Bug Product is not functioning as expected
Milestone
7.0.0-preview4

Comments

@jennyf19
Copy link
Collaborator

For example: https://github.com/AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet/blob/f5d06c36ee622f93996e9b7e3e25b8604140cf16/src/Microsoft.IdentityModel.JsonWebTokens/JsonWebTokenHandler.cs#L1473C1-L1474C1

This is usually inefficient and dangerous when present in hot path as it can lead to threadpool starvation.

Should I expose synchronous wrappers for asynchronous methods? - .NET Parallel Programming (microsoft.com)

AspNetCoreDiagnosticScenarios/AsyncGuidance.md at master · davidfowl/AspNetCoreDiagnosticScenarios (github.com)
@jennyf19 jennyf19 added this to the 7.0.0-preview4 milestone Aug 24, 2023
@jennyf19
Copy link
Collaborator Author

use obsolete attribute w/aka.ms link...delete in wilson 8.
leave as warning.

@westin-m westin-m self-assigned this Aug 24, 2023
@westin-m westin-m added the Bug Product is not functioning as expected label Aug 24, 2023
@westin-m westin-m mentioned this issue Aug 25, 2023
Merged
@keegan-caruso keegan-caruso linked a pull request Aug 25, 2023 that will close this issue
Mark synchronous wrapper as obsolete #2263
Merged
@jennyf19
Copy link
Collaborator Author

Included in preview4 release

@nathfy nathfy mentioned this issue Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westin-m westin-m

Labels
Bug Product is not functioning as expected
Projects
None yet
Milestone
7.0.0-preview4
2 participants
@jennyf19 @westin-m