Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeQL] Encryption using ECB, OFB or CFB #3110

Open
MichaelSimons opened this issue Jan 30, 2025 · 1 comment
Open

[CodeQL] Encryption using ECB, OFB or CFB #3110

MichaelSimons opened this issue Jan 30, 2025 · 1 comment
Labels
Enhancement The issue is a new feature

Comments

@MichaelSimons
Copy link

Applies to src/Microsoft.IdentityModel.Tokens/Encryption/SymmetricKeyWrapProvider.cs

Violation - Use of one of the following unsafe encryption modes that is not approved:

System.Security.Cryptography.CipherMode.ECB

System.Security.Cryptography.CipherMode.OFB

System.Security.Cryptography.CipherMode.CFB

These modes are vulnerable to attacks and may cause exposure of sensitive information. For example, using ECB to encrypt a plaintext block always produces a same cipher text, so it can easily tell if two encrypted messages are identical. Using approved modes can avoid these unnecessary risks.

@MichaelSimons
Copy link
Author

This .is getting flagged within .NET as azure-activedirectory-identitymodel-extensions-for-dotnet is included in it's source build graph.

@jennyf19 jennyf19 added the Enhancement The issue is a new feature label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The issue is a new feature
Projects
None yet
Development

No branches or pull requests

2 participants