Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Support Identity Federation #1591

Closed
jmprieur opened this issue Jan 8, 2022 · 1 comment
Closed

[Feature Request] Support Identity Federation #1591

jmprieur opened this issue Jan 8, 2022 · 1 comment
Labels
cert-less enhancement New feature or request
Milestone

Comments

@jmprieur
Copy link
Collaborator

jmprieur commented Jan 8, 2022

Is your feature request related to a problem? Please describe.

  • The cert-less scenario can be generalized into an identity federation scenario.
    Implicit Azure provider in MSAL (IMDS)

Describe the solution you'd like

  • Expose the notion of FederatedTokenProvider (which can be used by MSAL.NET to provide an assertion). This could be an abstract class. The issue is with how to cache the assertion. What is the key
  • Rename MsiSignedAssertionProvider into AzureFederatedTokenProvider and make it public. (Maybe remove the base class)
  • Expose an option EnableIdentityFederation
  • Expose a property FederatedClientId, which would contain the UserAssignedManagedIdentityClientId or the system assigned managed identity clientId, and would explicitly explain that this is for the identity federation scenario.

Describe alternatives you've considered

  • implicitly attempt the msi signed assertion provider when there are not credentials. But the v-team prefers things to be explicit
  • Keep the UserAssignedManagedIdentityClientId
  • We could also have a data structure in the configuration:
      "IdentityFederation" {
          "Enabled": true // default true
          " FederatedClientId" : Guid
       }
@jmprieur jmprieur added the enhancement New feature or request label Jan 8, 2022
@jennyf19 jennyf19 mentioned this issue Apr 6, 2022
@jennyf19 jennyf19 added this to the 1.24.0 milestone Apr 20, 2022
@jennyf19
Copy link
Collaborator

Released in 1.24.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cert-less enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants