Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Manipulate JSON using System.Text instead of Newtonsoft #182

Closed
bgavrilMS opened this issue May 29, 2020 · 3 comments · Fixed by #188
Closed

[Bug] Manipulate JSON using System.Text instead of Newtonsoft #182

bgavrilMS opened this issue May 29, 2020 · 3 comments · Fixed by #188
Assignees
@pmaytak
Labels
bug Something isn't working fixed .NET Core 5 P1
Milestone
0.1.5-preview

Comments

@bgavrilMS
Copy link
Member

Which Version of Microsoft Identity Web are you using ?
Note that to get help, you need to run the latest version.
0.1.3-preview

Where is the issue?

While Identity.Web does not reference Newtonsoft.Json directly, but via Wilson, it should rely on System.Text instead. This will make it easier to upgrade to latest Wilson. Also, System.Text is the preferred json serializer in the ASP.NET Core ecosystem.
@jmprieur jmprieur added bug Something isn't working P1 labels Jun 2, 2020
@jmprieur
Copy link
Collaborator

jmprieur commented Jun 2, 2020

We need to fix this before having the templates available in ASP.NET Core.

@jmprieur jmprieur added this to the 0.1.6-preview milestone Jun 2, 2020
@pmaytak pmaytak self-assigned this Jun 3, 2020
@pmaytak pmaytak modified the milestones: 0.1.6-preview, 0.1.5-preview Jun 3, 2020
@jmprieur
Copy link
Collaborator

jmprieur commented Jun 11, 2020 •
edited
Loading

Fixed by #188
@pmaytak : in the future please:

  • reference the fixed issues in your PR for traceability
  • changed the label (from "in progress" to "fixed") when the PRs are all merged

@pmaytak pmaytak linked a pull request Jun 11, 2020 that will close this issue
Replaced Newtonsoft.Json with System.Text.Json in projects. Plus minor misc fixes. #188
Merged
@pmaytak pmaytak mentioned this issue Jun 11, 2020
Closed
@pmaytak
Copy link
Contributor

pmaytak commented Jun 16, 2020

Fixed in Microsoft Identity Web 0.1.5-preview release.

@pmaytak pmaytak closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmaytak pmaytak

Labels
bug Something isn't working fixed .NET Core 5 P1
Projects
None yet
Milestone
0.1.5-preview
3 participants
@bgavrilMS @jmprieur @pmaytak